Closed Bug 1507988 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 14100 - [css-grid] Fix grid container sizing under min-content height

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 14100 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14100
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:
>  [css-grid] Fix grid container sizing under min-content height
>  
>  The spec is quite clear
>  (https://drafts.csswg.org/css-sizing/#valdef-width-min-content):
>    "min-content
>       If specified for the inline axis, use the min-content inline size;
>       otherwise behaves as the property’s initial value."
>  
>  So if a grid container has "height: min-content" it should behave
>  the same than with "height: auto".
>  
>  The patch removes ComputeIntrinsicLogicalContentHeightUsing() in
>  LayoutGrid as we don't need a custom one anymore.
>  We can also get rid of min_content_height_ and max_content_height_
>  attributes that were only used for this logic.
>  
>  BUG=906039
>  TEST=fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html
>  TEST=fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html
>  
>  Change-Id: Ia67d1dac16fbb04e3225115c3f34c67975dc6f94
>  Reviewed-on: https://chromium-review.googlesource.com/1340311
>  WPT-Export-Revision: 7ead2b7236ec20fcede968010e0a7dfaef2b1b6c
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests and 15 subtests
OK     : 1
PASS   : 9
FAIL   : 6

New tests that have failures or other problems:
/css/css-grid/grid-model/grid-container-sizing-constraints-001.html
    .grid 12: FAIL
    .grid 14: FAIL
    .grid 2: FAIL
    .grid 4: FAIL
    .grid 7: FAIL
    .grid 9: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6777091c9f3d
[wpt PR 14100] - [css-grid] Fix grid container sizing under min-content height, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/34463bf22296
[wpt PR 14100] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/6777091c9f3d
https://hg.mozilla.org/mozilla-central/rev/34463bf22296
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.