Closed Bug 1507993 Opened 1 year ago Closed 1 year ago

s/request_id/report_id/ in network-error-logging/support/lock.py

Categories

(Testing :: web-platform-tests, defect)

Version 3
defect
Not set

Tracking

(firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: KWierso, Assigned: KWierso)

Details

Attachments

(1 file)

Whenever the network-error-logging tests are run, it prints out the following traceback:
 0:35.08 WARNING Traceback (most recent call last):
  File "/Users/wkocher/mozilla/mozilla-central/testing/web-platform/tests/tools/wptserve/wptserve/handlers.py", line 310, in __call__
    rv = self.func(request, response)
  File "/Users/wkocher/mozilla/mozilla-central/testing/web-platform/tests/network-error-logging/support/lock.py", line 46, in main
    return unlock(request, report_id)
  File "/Users/wkocher/mozilla/mozilla-central/testing/web-platform/tests/network-error-logging/support/lock.py", line 34, in unlock
    if lock_holder != request_id:
NameError: global name 'request_id' is not defined

Nowhere in lock.py is request_id defined. I assume this is supposed to be report_id and was just mistyped during test creation?
"request_id" is never defined in the file, and it looks like it should be using "report_id" like most other places in this file.
Assignee: nobody → wkocher
Pinged dcreager via twitter to confirm this, since that's the only human I could find associated with bug 1472828 or https://github.com/web-platform-tests/wpt/pull/11758
Hi Wes, thanks for the patch! I am the owner of those WPT tests, and the attached patch looks like the right fix.  If you merge this, it will sync upstream automatically, right?  If not, you can also submit this as a PR on the upstream GitHub repo and I’d be able to approve/merge it there.
(In reply to dcreager from comment #3)
> Hi Wes, thanks for the patch! I am the owner of those WPT tests, and the
> attached patch looks like the right fix.  If you merge this, it will sync
> upstream automatically, right?  If not, you can also submit this as a PR on
> the upstream GitHub repo and I’d be able to approve/merge it there.

Pretty sure this should create a WPT PR automatically when this begins the landing process.
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/5f31d040aab4
Fix up a typo in network-error-logging/support/lock.py r=jgraham
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14123 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
https://hg.mozilla.org/mozilla-central/rev/5f31d040aab4
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.