LDAP autocomplete throws error when looking up recipients for composition offline

RESOLVED FIXED in Thunderbird 65.0

Status

enhancement
--
minor
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 65.0

Thunderbird Tracking Flags

(thunderbird_esr6064+ fixed, thunderbird64 fixed, thunderbird65 fixed)

Details

Attachments

(1 attachment)

When you compose with TB offline and type a recipient, the autocomplete kicks in searching in all addressbooks. An LDAP one obviously needs a network connection and throws an error that arrives in the Error console:

NS_ERROR_OFFLINE: Component returned failure code: 0x804b0010 (NS_ERROR_OFFLINE) [nsIAbDirectoryQuery.doQuery] nsAbLDAPAutoCompleteSearch.js:264

I think nsAbLDAPAutoCompleteSearch.js should skip trying to run LDAP queries when TB is offline. We can do it silently, or notify the user in some way.
Posted patch 1508046.patchSplinter Review
Attachment #9025873 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9025873 [details] [diff] [review]
1508046.patch

Review of attachment 9025873 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin
Attachment #9025873 - Flags: review?(mkmelin+mozilla) → review+
Thanks.
Keywords: checkin-needed
Comment on attachment 9025873 [details] [diff] [review]
1508046.patch

Worthwhile to uplift.
Attachment #9025873 - Flags: approval-comm-esr60+
Attachment #9025873 - Flags: approval-comm-beta+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8cf3f95e48e8
return cleanly in LDAP autocomplete search if we are offline. r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
You need to log in before you can comment on or make changes to this bug.