Closed
Bug 1508046
Opened 6 years ago
Closed 6 years ago
LDAP autocomplete throws error when looking up recipients for composition offline
Categories
(MailNews Core :: Address Book, enhancement)
MailNews Core
Address Book
Tracking
(thunderbird_esr6064+ fixed, thunderbird64 fixed, thunderbird65 fixed)
RESOLVED
FIXED
Thunderbird 65.0
People
(Reporter: aceman, Assigned: aceman)
Details
Attachments
(1 file)
|
1.21 KB,
patch
|
mkmelin
:
review+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
When you compose with TB offline and type a recipient, the autocomplete kicks in searching in all addressbooks. An LDAP one obviously needs a network connection and throws an error that arrives in the Error console:
NS_ERROR_OFFLINE: Component returned failure code: 0x804b0010 (NS_ERROR_OFFLINE) [nsIAbDirectoryQuery.doQuery] nsAbLDAPAutoCompleteSearch.js:264
I think nsAbLDAPAutoCompleteSearch.js should skip trying to run LDAP queries when TB is offline. We can do it silently, or notify the user in some way.
Attachment #9025873 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9025873 [details] [diff] [review]
1508046.patch
Review of attachment 9025873 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thx! r=mkmelin
Attachment #9025873 -
Flags: review?(mkmelin+mozilla) → review+
|
||
Comment 4•6 years ago
|
||
Comment on attachment 9025873 [details] [diff] [review]
1508046.patch
Worthwhile to uplift.
Attachment #9025873 -
Flags: approval-comm-esr60+
Attachment #9025873 -
Flags: approval-comm-beta+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8cf3f95e48e8
return cleanly in LDAP autocomplete search if we are offline. r=mkmelin
|
|
||
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 65.0
|
|
||
Comment 6•6 years ago
|
||
Beta (TB 64 beta 3):
https://hg.mozilla.org/releases/comm-beta/rev/e0e70ed02daa
status-thunderbird64:
--- → fixed
status-thunderbird65:
--- → fixed
status-thunderbird_esr60:
--- → affected
|
|
||
Comment 7•6 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•