Closed Bug 1508080 Opened 5 years ago Closed 5 years ago

[RTL] On an extension page, the identity-icon-label text appears in reverse

Categories

(Firefox :: Theme, defect, P3)

defect

Tracking

()

VERIFIED FIXED
Firefox 71
Tracking Status
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox71 --- verified

People

(Reporter: itiel_yn8, Assigned: itiel_yn8)

Details

(Keywords: rtl)

Attachments

(3 files, 1 obsolete file)

See attached for how this looks on RTL (the hebrew text should be on the right side of the extension name).

Adding this rule to browser.css seems to fix it:

#identity-icon-label:-moz-locale-dir(rtl) {
  direction: rtl !important;
}

but I guess there was a reason for force-ltr'ing it for all cases, so I'm not sure this is the right fix.
Attached image Screenshot
Attached image After the CSS fix
To clarify:
On RTL builds, when entering an extension's page (moz-extension://), the text on the identity panel (on the URL bar) appears in reverse (so, according to the attached screenshot, it reads as "(Tab Session Manager) Extension" instead of "Extension (Tab Session Manager)").
The CSS fix forces direction: rtl on the text if the app's locale is RTL.
(In reply to Itiel from comment #0)
> Adding this rule to browser.css seems to fix it:
> 
> #identity-icon-label:-moz-locale-dir(rtl) {
>   direction: rtl !important;
> }

Or, better yet:

#identity-icon-label {
  unicode-bidi: plaintext;
}

... if for some reason all the text there is LTR.
I see that identity-icon-country-label has direction: ltr, I don't see a directionality on identity-icon-label or identity-icon-labels.

Would you mind converting comment 4 in a patch and asking for review to Dao?
Component: Address Bar → Theme
Flags: needinfo?(itiel_yn8)
(In reply to Marco Bonardo [::mak] from comment #5)
> Would you mind converting comment 4 in a patch and asking for review to Dao?

Would love to, problem is I'm on Windows 10 and as far as I can tell (and as I've heard), it's not best suited for developing. Besides I have only 4GB RAM and a somewhat sluggish PC.
Could this be mentored to someone else, as a GFB or something?
Flags: needinfo?(itiel_yn8)
I do code on Windows 10, there's usually no problem with that, though 8GB RAM is suggested.
(In reply to Marco Bonardo [::mak] from comment #7)
> I do code on Windows 10, there's usually no problem with that, though 8GB
> RAM is suggested.

Forgot to mention- I'm using x86 Windows, so.. Not an option :(
Priority: -- → P3

Marco, can someone use comment 4 to make a fix for 67?

Flags: needinfo?(mak77)

Probably yes, it should be tested to check it doesn't cause other problems.

Flags: needinfo?(mak77)
Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Attachment #9083372 - Attachment is obsolete: true
Attachment #9085520 - Attachment description: Bug 1508080 - Set identity-icon-label direction to RTL on an extension page for RTL locales → Bug 1508080 - Don't set directionality on identity-icon-labels on extension pages r?dao
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74c70e9a5ec2
Don't set directionality on identity-icon-labels on extension pages r=dao
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: