Make tab line color fallback to the selected tab text color instead of accentcolor

RESOLVED FIXED in Firefox 65

Status

()

defect
P2
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: ntim, Assigned: dao)

Tracking

Trunk
Firefox 65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

See https://bugzilla.mozilla.org/show_bug.cgi?id=1506913#c4

Right now, the tab line color falls back to the accentcolor on themes. This is problematic because themes with a background image will use accentcolor instead of setting the tab_line property. Setting accentcolor has more consequences than just changing the tab line color, but unfortunately, for themes with background images, those consequences are less visible, causing bugs like bug 1506913.

This is the same bug that made Quantum lights break Tree Style Tabs, since Quantum Lights used accentcolor: white to change the tab line color.

I'm proposing to following steps to fix this problem:
- make the tab line color fallback to the textcolor, since textcolor is used for most of the browser window's textcolor by default, which will make theme authors more aware of the impact. This is also makes more sense as the tab line is a foreground item, and not a background item.
- Fix https://github.com/mozilla/addons-frontend/issues/6963
- Maybe run a mass migration for all themes incorrectly using accentcolor, the condition is pretty easy to check:

(does not have tab_line) && (has accentcolor) && (has headerURL)
Also, maybe we could add extra accessibility checks to the theme reviewing checklist: check the appearance of the find toolbar (bug 1506913), etc..
Mike, what do you think ?
Flags: needinfo?(mconca)
See Also: → 1506913
In the case of bug 1506913, https://addons.mozilla.org/en-US/firefox/addon/galaxy-blue/ has set the accentcolor to the same value as the textcolor (they're both white), which is problematic, because the text color and the background color have 0 contrast if the header image is removed.

If we could add warnings/errors in the theme submitter, that would be helpful too.
Blocks: 1388138
Component: Themes → Theme
Priority: -- → P2
Product: WebExtensions → Firefox
Version: unspecified → Trunk
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Blocks: 1506913
See Also: 1506913
Attachment #9028257 - Attachment description: Bug 1508081 - Make tab line color fallback to textcolor instead of accentcolor. r=ntim → Bug 1508081 - Make tab line color fallback to the selected tab text color instead of accentcolor. r=ntim
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e55f708271a
Make tab line color fallback to the selected tab text color instead of accentcolor. r=ntim
Summary: Make tab line color fallback to textcolor instead of accentcolor → Make tab line color fallback to the selected tab text color instead of accentcolor
https://hg.mozilla.org/mozilla-central/rev/4e55f708271a
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Flags: needinfo?(mconca)
You need to log in before you can comment on or make changes to this bug.