Closed Bug 1508085 Opened 2 years ago Closed 2 years ago
Track the sizes of commonly used node types also in 32 bit builds
I need some more bits on nsINode, but better to ensure we don't increase the sizes of commonly used node types accidentally. EXTRA_DOM_NODE_BYTES is 8 even on 32bit just to be safe with different alignments. It affects anyhow only debug builds. Right now on 64bit nsINode has 4 bytes for use without any change to sizes. On 32bit if one wants 4 bytes on Element, mAttrs need to move from FragmentOrElement to Element (which makes sense anyhow). That way alignment is better and 4 bytes on nsINode can be used for flags and still keeping Element size <= 80. But Text is trickiest. It is using 64 bytes on 32bit. But then, Text nodes don't use mChildCount or mFirstChild for anything. https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a8ba68490e7d63d6a9c9168e61cd8435d4b8d63
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/9cdaafe18302 Track the sizes of commonly used node types also in 32 bit builds, r=ehsan
You need to log in before you can comment on or make changes to this bug.