1508085 - Track the sizes of commonly used node types also in 32 bit builds

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Olli Pettay [:smaug][[e-mail]]]

I need some more bits on nsINode, but better to ensure we don't increase the sizes of commonly used node types accidentally.

EXTRA_DOM_NODE_BYTES is 8 even on 32bit just to be safe with different alignments.
It affects anyhow only debug builds.


Right now on 64bit nsINode has 4 bytes for use without any change to sizes.
On 32bit if one wants 4 bytes on Element, mAttrs need to move from FragmentOrElement to Element (which makes sense anyhow). That way alignment is
better and 4 bytes on nsINode can be used for flags and still keeping Element size <= 80.
But Text is trickiest. It is using 64 bytes on 32bit. But then, Text nodes don't use mChildCount or mFirstChild for anything.


https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a8ba68490e7d63d6a9c9168e61cd8435d4b8d63

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: more_nsinode_flags_32bit_report_only.diff

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cdaafe18302
Track the sizes of commonly used node types also in 32 bit builds, r=ehsan

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/9cdaafe18302