1508097 - Use consistent formatting for JS_FN + family

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Ted Campbell [:tcampbell]]

These are a source of formatting grossness, especially when mixing JS_FN/JS_SELFHOSTING_FN/etc. Some use |clang-format off| and others avoid it. The primary reason for avoiding clang-format here is that bin-packing makes a mess of it. Some of these protected uses have bad formatting to begin with and should probably be fixed (https://searchfox.org/mozilla-central/rev/e67e6f648b1d0977f7610154da731ddf0e4f31f0/js/src/vm/SelfHosting.cpp#2384-2798).

It seems generally tabular white-spacing has not been beneficial for us. I'd propose we get rid of their extra whitespace, but use |clang-format off| to keep exactly one JS_FN per line and avoid weird breaks. Feedback is needed here!

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1508097 - Remove clang-format off/on annotations for JSFunctionSpec arrays. r?tcampbell

We have a lot of these arrays and some used clang-format off/on, some are
formatted like a table, etc. We decided it's best to reformat and get rid of
the tabular structure.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b3783d7fa53
Remove clang-format off/on annotations for JSFunctionSpec arrays. r=tcampbell

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/2b3783d7fa53

Comment 4

[(no longer active)]

Attachment: ESR patch

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): comment only

String or UUID changes made by this patch: None

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9030796 [details] [diff] [review]
ESR patch

OK for uplift to ESR60 as part of the clang-format project.

Comment 6

[(no longer active)]

https://hg.mozilla.org/releases/mozilla-esr60/rev/9f2db2f1993c