Closed Bug 1508131 Opened 5 years ago Closed 5 years ago

Use Fluent for about:serviceworkers

Categories

(Core :: DOM: Service Workers, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: songqing, Assigned: songqing)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36

Steps to reproduce:

This bug covers converting about:serviceworkers ( https://searchfox.org/mozilla-central/source/toolkit/content/aboutServiceWorkers.xhtml) to using Fluent for localization.
Assignee: nobody → songqing
Status: UNCONFIRMED → ASSIGNED
Component: Untriaged → DOM: Service Workers
Ever confirmed: true
Product: Firefox → Core
Gijs, it looks like this bug is related to the browser interface and not to the platform itself. Is there a reason why this should be in the Core product?
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Yaron Tausky [:ytausky] from comment #1)
> Gijs, it looks like this bug is related to the browser interface

It relates to about:serviceworkers, which is pretty tightly coupled to our actual platform service worker implementation.

> and not to
> the platform itself. Is there a reason why this should be in the Core
> product?

about:serviceworkers  was implemented in bug 1133601, which was in Core :: DOM: Workers. The last change to the XHTML file was bug 1326542, which also lived in Core :: DOM: Service Workers (which probably didn't exist yet as a separate component from DOM: Workers when 1133601 was filed). Either way, I'm confident Core is the right place.
Flags: needinfo?(gijskruitbosch+bugs)
Okay, thanks for clarifying.
Priority: -- → P3
Note that bug 1273821 covers removing about:serviceworkers.
(In reply to Andrew Sutherland [:asuth] from comment #4)
> Note that bug 1273821 covers removing about:serviceworkers.

Should we fix that bug instead? bug 1220747 is still open, though it has no open deps, so I'm not really sure.
Flags: needinfo?(bugmail)
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/16e07c6f1e1d
Migrate about:serviceworkers to use Fluent for localization r=Gijs,flod,zbraniecki
https://hg.mozilla.org/mozilla-central/rev/16e07c6f1e1d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Flags: needinfo?(bugmail)
You need to log in before you can comment on or make changes to this bug.