1508141 - Remove support for disableKeyNavigation on richlistbox, autocomplete and tree bindings

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P5)

Description

[Tim Nguyen :ntim]

This disableKeyNavigation attribute is unused in mozilla-central and is only used in comm-central in the suite/ folder (SeaMonkey).

https://searchfox.org/mozilla-central/search?q=disableKeyNavigation&case=false&regexp=false&path=

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1508141 - Remove support for disableKeyNavigation on richlistbox, autocomplete and tree bindings;r=timdream

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adad39927668
Remove support for disableKeyNavigation on richlistbox, autocomplete and tree bindings;r=timdream

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/adad39927668

Comment 4

[Magnus Melin [:mkmelin]]

(In reply to :ntim (low availability until February) from comment #0)
> is only used in comm-central in the suite/ folder (SeaMonkey).

No it's used in mail and mailnews (=> Thunderbird) too. Use it e.g. for single key actions (move forward, archive etc.) while the tree still have focus.
https://searchfox.org/comm-central/search?q=disableKeyNavigation&path=mail

Comment 5

[Tim Nguyen :ntim]

(In reply to Magnus Melin [:mkmelin] from comment #4)
> (In reply to :ntim (low availability until February) from comment #0)
> > is only used in comm-central in the suite/ folder (SeaMonkey).
> 
> No it's used in mail and mailnews (=> Thunderbird) too. Use it e.g. for
> single key actions (move forward, archive etc.) while the tree still have
> focus.
> https://searchfox.org/comm-central/search?q=disableKeyNavigation&path=mail

Oops, I guess it would be possible to reintroduce support for the attribute in the tree binding. Brian, what do you think ?

Comment 6

[Tim Nguyen :ntim]

(Since it seems only used in the tree binding in c-c)

Comment 7

[Magnus Melin [:mkmelin]]

That would be great. Since as AIUI, you're going to completely remove <tree> eventually, removing m-c unused properties from it now seems a bit unnecessary to me.

Comment 8

[Alfred Peters]

(In reply to Magnus Melin [:mkmelin] from comment #4)

> No it's used in mail and mailnews (=> Thunderbird) too. Use it e.g. for
> single key actions (move forward, archive etc.) while the tree still have
> focus.

Indeed: -> Bug 1515759

Comment 9

[Brian Grinstead [:bgrins]]

Sure, it could be reintroduced into <tree> in Bug 1515759