Closed Bug 1508141 Opened 3 years ago Closed 3 years ago

Remove support for disableKeyNavigation on richlistbox, autocomplete and tree bindings

Categories

(Toolkit :: XUL Widgets, task, P5)

task

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: ntim, Assigned: bgrins)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This disableKeyNavigation attribute is unused in mozilla-central and is only used in comm-central in the suite/ folder (SeaMonkey).

https://searchfox.org/mozilla-central/search?q=disableKeyNavigation&case=false&regexp=false&path=
Priority: -- → P5
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/adad39927668
Remove support for disableKeyNavigation on richlistbox, autocomplete and tree bindings;r=timdream
https://hg.mozilla.org/mozilla-central/rev/adad39927668
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
(In reply to :ntim (low availability until February) from comment #0)
> is only used in comm-central in the suite/ folder (SeaMonkey).

No it's used in mail and mailnews (=> Thunderbird) too. Use it e.g. for single key actions (move forward, archive etc.) while the tree still have focus.
https://searchfox.org/comm-central/search?q=disableKeyNavigation&path=mail
(In reply to Magnus Melin [:mkmelin] from comment #4)
> (In reply to :ntim (low availability until February) from comment #0)
> > is only used in comm-central in the suite/ folder (SeaMonkey).
> 
> No it's used in mail and mailnews (=> Thunderbird) too. Use it e.g. for
> single key actions (move forward, archive etc.) while the tree still have
> focus.
> https://searchfox.org/comm-central/search?q=disableKeyNavigation&path=mail

Oops, I guess it would be possible to reintroduce support for the attribute in the tree binding. Brian, what do you think ?
Flags: needinfo?(bgrinstead)
(Since it seems only used in the tree binding in c-c)
That would be great. Since as AIUI, you're going to completely remove <tree> eventually, removing m-c unused properties from it now seems a bit unnecessary to me.
(In reply to Magnus Melin [:mkmelin] from comment #4)

> No it's used in mail and mailnews (=> Thunderbird) too. Use it e.g. for
> single key actions (move forward, archive etc.) while the tree still have
> focus.

Indeed: -> Bug 1515759
Sure, it could be reintroduced into <tree> in Bug 1515759
Flags: needinfo?(bgrinstead)
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.