Closed Bug 1508143 Opened 10 months ago Closed 10 months ago

Remove builderView and contentView from tree binding

Categories

(Toolkit :: XUL Widgets, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Bug 202391 and bug 202393 simply made those aliases of `view`.

There are two usages in m-c of contentView, which can be changed to view.
Good find - looks like all references to `builderView` and `contentView` can be replaced with `view` as per Bug 202391 / https://searchfox.org/mozilla-central/rev/b03a62c3c82316e733a3b09622c1cb7e59f64cc3/toolkit/content/widgets/tree.xml#71-78. I don't see any reason not to do this as a cleanup - comm-central will need to be updated as well:

- https://searchfox.org/comm-central/search?q=builderView&path=
- https://searchfox.org/comm-central/search?q=symbol:%23contentView&redirect=false
Flags: needinfo?(jorgk)
Depends on: 1508343
Thanks, I filed bug 1508343. Can we do this now or do we need to wait for this bug here to land? Now, right?
Flags: needinfo?(jorgk)
(In reply to Jorg K (GMT+1) from comment #3)
> Thanks, I filed bug 1508343. Can we do this now or do we need to wait for
> this bug here to land? Now, right?

Yes, you can do it now.
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/56372a3d2856
Remove builderView and contentView from tree binding. r=bgrins
Assignee: nobody → ntim.bugs
https://hg.mozilla.org/mozilla-central/rev/56372a3d2856
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/aa07a415e647
Port bug 1508143: Replace use of tree binding's .builderView and .contentView with .view. r=jorgk
Sorry, comment #7 was meant to go into bug 1508343, but somehow the bug number in to commit message was wrong :-(
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.