Closed Bug 1508143 Opened 10 months ago Closed 10 months ago
View and content View from tree binding
47 bytes, text/x-phabricator-request
|Details | Review|
Bug 202391 and bug 202393 simply made those aliases of `view`. There are two usages in m-c of contentView, which can be changed to view.
Good find - looks like all references to `builderView` and `contentView` can be replaced with `view` as per Bug 202391 / https://searchfox.org/mozilla-central/rev/b03a62c3c82316e733a3b09622c1cb7e59f64cc3/toolkit/content/widgets/tree.xml#71-78. I don't see any reason not to do this as a cleanup - comm-central will need to be updated as well: - https://searchfox.org/comm-central/search?q=builderView&path= - https://searchfox.org/comm-central/search?q=symbol:%23contentView&redirect=false
Thanks, I filed bug 1508343. Can we do this now or do we need to wait for this bug here to land? Now, right?
(In reply to Jorg K (GMT+1) from comment #3) > Thanks, I filed bug 1508343. Can we do this now or do we need to wait for > this bug here to land? Now, right? Yes, you can do it now.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/56372a3d2856 Remove builderView and contentView from tree binding. r=bgrins
Pushed by email@example.com: https://hg.mozilla.org/comm-central/rev/aa07a415e647 Port bug 1508143: Replace use of tree binding's .builderView and .contentView with .view. r=jorgk
Sorry, comment #7 was meant to go into bug 1508343, but somehow the bug number in to commit message was wrong :-(
You need to log in before you can comment on or make changes to this bug.