Closed
Bug 1508147
Opened 7 years ago
Closed 7 years ago
Remove isAddonCompartment again
Categories
(Core :: XPConnect, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: robwu, Assigned: timdream)
References
Details
Attachments
(1 file)
The code at [1] and [2] should probably be removed.
It was originally removed by https://hg.mozilla.org/mozilla-central/rev/49dceb93cc0c in bug 1478275,
but reintroduced by https://hg.mozilla.org/mozilla-central/rev/74adb43ed112 (bug 1431255).
The re-introduction doesn't appear to be intentional (failed rebase?), so the code can probably be removed again.
[1] https://searchfox.org/mozilla-central/rev/5117a4c4e29fcf80a627fecf899a62f117368abf/js/xpconnect/src/xpcprivate.h#2944-2947
[2] https://searchfox.org/mozilla-central/rev/e67e6f648b1d0977f7610154da731ddf0e4f31f0/js/xpconnect/src/XPCJSRuntime.cpp#195
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(timdream)
|
|
Assignee | |
Comment 1•7 years ago
|
||
Yeah it a false rebase.
Assignee: nobody → timdream
Status: NEW → ASSIGNED
Flags: needinfo?(timdream)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Thank you for filing!
|
|
Assignee | |
Comment 3•7 years ago
|
||
It was removed in bug 1478275, but re-introduced because of a false rebase in bug 1431255.
Pushed by tchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bd4cebdbed4b
Re-remove unused CompartmentPrivate::isAddonCompartment, r=bholley
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•