Closed Bug 1508157 Opened Last year Closed Last year

Port bug 1468517: Make toolbar_bottom_separator color apply to findbar top border

Categories

(Thunderbird :: Theme, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 65.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

In bug 1468517 FX applies now the toolbar_bottom_separator color to the findbar top border.
This patch adds not only the top-border-color to the findbar, it also changes the variable name from --toolbox-border-bottom-color to --chrome-content-separator-color to better fit the changed use. This is what m-c does too, see https://hg.mozilla.org/integration/autoland/rev/7e9cac76980a.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9025947 - Flags: review?(jorgk)
Comment on attachment 9025947 [details] [diff] [review]
1508157-findbar-top-border.patch

Review of attachment 9025947 [details] [diff] [review]:
-----------------------------------------------------------------

Looks OK to me.

::: mail/themes/linux/mail/messenger.css
@@ +827,5 @@
>  
>  findbar:-moz-lwtheme {
>    background-color: var(--lwt-accent-color);
>    background-image: linear-gradient(var(--toolbar-bgcolor), var(--toolbar-bgcolor));
> +  border-top-color: var(--chrome-content-separator-color);

So this is the net change here, times three, for Mac and Windows. The rest is just renaming stuff.
Attachment #9025947 - Flags: review?(jorgk) → review+
(In reply to Jorg K (GMT+1) from comment #2)
> Comment on attachment 9025947 [details] [diff] [review]
> 1508157-findbar-top-border.patch
> 
> Review of attachment 9025947 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks OK to me.
> 
> ::: mail/themes/linux/mail/messenger.css
> @@ +827,5 @@
> >  
> >  findbar:-moz-lwtheme {
> >    background-color: var(--lwt-accent-color);
> >    background-image: linear-gradient(var(--toolbar-bgcolor), var(--toolbar-bgcolor));
> > +  border-top-color: var(--chrome-content-separator-color);
> 
> So this is the net change here, times three, for Mac and Windows. The rest
> is just renaming stuff.

Correct.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e975eec95a7e
Port bug 1468517: Make toolbar_bottom_separator color apply to findbar top border. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.