1508159 - On Windows with dark theme the QFB result isn't readable

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Richard Marti (:Paenglab)]

On Windows with the dark theme applied when I search something with the QFB, the found messages are on a light background with with white text - not very readable.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1508159-unify-qfb.patch

I moved some rules that are on all themes the same to content/quickFilterBar.css. We don't need any more to be compatible to 3rd party themes.

On Windows, when the search found something it set a light background. We don't need this as the the showed messages are enough to show it has found something. The Linux way with the outline was not very visible. When nothing is found, a red striped background is shown. I also moved a toolbarbutton-1 rule to the shared file to work the same on all platforms. Before, the qfb-tag-button didn't showed the tag colour on Mac and Windows.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9025948 [details] [diff] [review]
1508159-unify-qfb.patch

Review of attachment 9025948 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/content/quickFilterBar.css
@@ +69,5 @@
>  }
> +
> +#threadTree[filterActive="nomatches"] > .tree-stack {
> +  background: repeating-linear-gradient(-45deg, rgba(255,102,102,.6),
> +              rgba(255,102,102,.6) 10px, transparent 10px, transparent 20px);

It's a bit much of the colors perhaps.
And especially as it's not an error maybe we shouldn't use red.

In general, would be nice if we could just use an svg image with an embedded message about "nothing found for that", and also something similar for empty folders.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1508159-unify-qfb.patch v2

(In reply to Magnus Melin [:mkmelin] from comment #2)
> 
> In general, would be nice if we could just use an svg image with an embedded
> message about "nothing found for that", and also something similar for empty
> folders.

Like this? Only the icon. I don't know if and how we could add text in to the tree.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: 1508159-unify-qfb.patch (svg with text for the "no results" string

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9025957 [details] [diff] [review]
1508159-unify-qfb.patch v2

Review of attachment 9025957 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah this is nice.
I attached a patch with localized text in the svg. Works but may need some polishing.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1508159-unify-qfb.patch

Didn't know that this works with the dtd file.

Centered the text and made the svg wide enough that all locales should fit. Unfortunately it seems that fill="context-fill" doesn't apply on text. I've set now GrayText to work on standard- and dark themes.

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9026501 [details] [diff] [review]
1508159-unify-qfb.patch

Review of attachment 9026501 [details] [diff] [review]:
-----------------------------------------------------------------

Great! Perhaps keep the red top+bottom of the thread pane for not found? Somehow it's not as clear that the quick filter is connected to there without that. 
r=mkmelin

Comment 8

[Richard Marti (:Paenglab)]

I think the red top/bottom lines don't connect the QFB with the tree when nothing is found. I leave it now as it is.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/997a46907023
Unify some quickfilterbar rules and fix the qfb-tag-button colors. r=mkmelin