Closed Bug 1508160 Opened Last year Closed Last year

Add JS_BEGIN_MACRO to .clang-format

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox-esr60 --- fixed
firefox65 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

References

Details

Attachments

(1 file)

We use MacroBeginBlock modifers in the .clang-format to indicate macros for blocks. We should add JS_BEGIN_MACRO/JS_END_MACRO to these lists.
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb04ab1f698a
Add JS_BEGIN_MACRO to .clang-format r=sylvestre
https://hg.mozilla.org/mozilla-central/rev/eb04ab1f698a
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment on attachment 9025951 [details]
Bug 1508160 - Add JS_BEGIN_MACRO to .clang-format

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): NPOTB

String or UUID changes made by this patch: None
Attachment #9025951 - Flags: approval-mozilla-esr60?
Comment on attachment 9025951 [details]
Bug 1508160 - Add JS_BEGIN_MACRO to .clang-format

OK for uplift to ESR60 as part of the clang-format project.
Attachment #9025951 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.