Closed Bug 1508171 Opened 4 years ago Closed 3 years ago

Remove gBrowser.initialBrowser

Categories

(Firefox :: Tabbed Browser, task, P3)

Product:
Firefox
Component:
Tabbed Browser
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: Gijs, Assigned: dao)

References

Details

Attachments

(1 file)

Bug 1508171 - Remove gBrowser.initialBrowser. r=gijs
47 bytes, text/x-phabricator-request
Details | Review 
After bug 1506608 we don't actually need this property in the browser, so we should just remove it.
Joel, I'm seeing this in searchfox, can I just change this in m-c or is there another repo for these tests? ( https://searchfox.org/mozilla-central/search?q=.initialBrowser )
Component: General → Talos
Flags: needinfo?(jmaher)
Product: Firefox → Testing
(In reply to :Gijs (he/him) from comment #1)
> Joel, I'm seeing this in searchfox, can I just change this in m-c or is
> there another repo for these tests? (
> https://searchfox.org/mozilla-central/search?q=.initialBrowser )

Better link:

https://searchfox.org/mozilla-central/search?q=.initialBrowser&case=false&regexp=false&path=talos
that is the only place for talos code, so if you update and validate the results on try, that would be excellent.
Flags: needinfo?(jmaher)
Priority: -- → P3

XULBrowserWindow.forceInitialBrowserNonRemote also uses gBrowser.initialBrowser. Afaik we can just use gBrowser.selectedBrowser or gBrowser.browsers[0] there.

Type: enhancement → task
status-firefox65: affected → ---
Component: Talos → Tabbed Browser
Product: Testing → Firefox
Summary: Make pageloader tests not access gBrowser.initialBrowser so we can get rid of it. → Remove gBrowser.initialBrowser
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Blocks: 1616603
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e4eb113462e
Remove gBrowser.initialBrowser. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/9e4eb113462e

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
You need to log in before you can comment on or make changes to this bug.