Closed
Bug 1508171
Opened 7 years ago
Closed 5 years ago
Remove gBrowser.initialBrowser
Categories
(Firefox :: Tabbed Browser, task, P3)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: Gijs, Assigned: dao)
References
Details
Attachments
(1 file)
After bug 1506608 we don't actually need this property in the browser, so we should just remove it.
|
Reporter | |
Comment 1•7 years ago
|
||
Joel, I'm seeing this in searchfox, can I just change this in m-c or is there another repo for these tests? ( https://searchfox.org/mozilla-central/search?q=.initialBrowser )
Component: General → Talos
Flags: needinfo?(jmaher)
Product: Firefox → Testing
|
|
Reporter | |
Comment 2•7 years ago
|
||
(In reply to :Gijs (he/him) from comment #1)
> Joel, I'm seeing this in searchfox, can I just change this in m-c or is
> there another repo for these tests? (
> https://searchfox.org/mozilla-central/search?q=.initialBrowser )
Better link:
https://searchfox.org/mozilla-central/search?q=.initialBrowser&case=false®exp=false&path=talos
|
||
Comment 3•7 years ago
|
||
that is the only place for talos code, so if you update and validate the results on try, that would be excellent.
Flags: needinfo?(jmaher)
|
||
Updated•6 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 4•5 years ago
|
||
XULBrowserWindow.forceInitialBrowserNonRemote also uses gBrowser.initialBrowser. Afaik we can just use gBrowser.selectedBrowser or gBrowser.browsers[0] there.
Type: enhancement → task
status-firefox65:
affected → ---
Component: Talos → Tabbed Browser
Product: Testing → Firefox
Summary: Make pageloader tests not access gBrowser.initialBrowser so we can get rid of it. → Remove gBrowser.initialBrowser
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e4eb113462e
Remove gBrowser.initialBrowser. r=Gijs
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
You need to log in
before you can comment on or make changes to this bug.
Description
•