Closed Bug 1508211 Opened 9 months ago Closed 9 months ago

[wpt-sync] Sync PR 14121 - CSS: Serialize % before px in calc

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 14121 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14121
Details from upstream follow.

Eric Willigers <ericwilligers@chromium.org> wrote:
>  CSS: Serialize % before px in calc
>  
>  https://drafts.csswg.org/css-values/#math-function-serialize-a-summation
>  Percentage should be serialized before dimensions with units
>  
>  Also fix typo in WPTs svg/geometry/parsing/*-computed.svg
>  calc(50% + 60x) becomes calc(50% + 60px)
>  
>  Change-Id: I2ecb732564c405f9315a1ef06e5bd0777c407f19
>  Reviewed-on: https://chromium-review.googlesource.com/1341289
>  WPT-Export-Revision: 72f180571639e8a25b9137e172798fff9356e97a
PR 14121 applied with additional changes from upstream: 39c2331ea623e23849d2f6fc99f804e5e2d374d2, 744325921ba52791bc8db1b45d2aed097577753a
Component: web-platform-tests → SVG
Product: Testing → Core
Component: SVG → CSS Parsing and Computation
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 24 tests and 2275 subtests
OK     : 22
PASS   : 2165
FAIL   : 112

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/css/css-align/gaps/column-gap-parsing-001.html
    column-gap accepts calc() mixing fixed and percentage values: FAIL
/css/css-align/gaps/gap-parsing-001.html
    gap accepts calc() mixing fixed and percentage values: FAIL
/css/css-align/gaps/grid-column-gap-parsing-001.html
    grid-column-gap accepts calc() mixing fixed and percentage values: FAIL
/css/css-align/gaps/grid-gap-parsing-001.html
    grid-gap accepts calc() mixing fixed and percentage values: FAIL
/css/css-align/gaps/grid-row-gap-parsing-001.html
    grid-row-gap accepts calc() mixing fixed and percentage values: FAIL
/css/css-align/gaps/row-gap-parsing-001.html
    row-gap accepts calc() mixing fixed and percentage values: FAIL
/web-animations/animation-model/animation-types/accumulation-per-property.html
    flex-basis: calc: FAIL
    flex-basis: units "%" onto "px": FAIL
    flex-basis: units "%" onto "rem": FAIL
    flex-basis: units "calc" onto "px": FAIL
    flex-basis: units "px" onto "%": FAIL
    flex-basis: units "rem" onto "%": FAIL
    word-spacing: calc: FAIL
    word-spacing: units "%" onto "px": FAIL
    word-spacing: units "%" onto "rem": FAIL
    word-spacing: units "calc" onto "px": FAIL
    word-spacing: units "px" onto "%": FAIL
    word-spacing: units "rem" onto "%": FAIL
/web-animations/animation-model/animation-types/addition-per-property.html
    flex-basis: calc: FAIL
    flex-basis: units "%" onto "px": FAIL
    flex-basis: units "%" onto "rem": FAIL
    flex-basis: units "calc" onto "px": FAIL
    flex-basis: units "px" onto "%": FAIL
    flex-basis: units "rem" onto "%": FAIL
    word-spacing: calc: FAIL
    word-spacing: units "%" onto "px": FAIL
    word-spacing: units "%" onto "rem": FAIL
    word-spacing: units "calc" onto "px": FAIL
    word-spacing: units "px" onto "%": FAIL
    word-spacing: units "rem" onto "%": FAIL
/web-animations/animation-model/animation-types/interpolation-per-property.html
    flex-basis supports animating as a calc: FAIL
    flex-basis supports animating as combination units "%" and "em": FAIL
    flex-basis supports animating as combination units "px" and "%": FAIL
    flex-basis supports animating as combination units "px" and "calc": FAIL
    word-spacing supports animating as a calc: FAIL
    word-spacing supports animating as combination units "%" and "em": FAIL
    word-spacing supports animating as combination units "px" and "%": FAIL
    word-spacing supports animating as combination units "px" and "calc": FAIL

New tests that have failures or other problems:
/svg/painting/parsing/stroke-width-computed.svg
    Property stroke-width value '10' computes to '10px': FAIL
    Property stroke-width value 'calc(50% + 60px)' computes to 'calc(50% + 60px)': FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f18b7b652c4
[wpt PR 14121] - CSS: Serialize % before px in calc, a=testonly
https://hg.mozilla.org/mozilla-central/rev/0f18b7b652c4
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.