1508211 - [wpt-sync] Sync PR 14121 - CSS: Serialize % before px in calc

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 14121 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14121
Details from upstream follow.

Eric Willigers <[e-mail]> wrote:
>  CSS: Serialize % before px in calc
>  
>  https://drafts.csswg.org/css-values/#math-function-serialize-a-summation
>  Percentage should be serialized before dimensions with units
>  
>  Also fix typo in WPTs svg/geometry/parsing/*-computed.svg
>  calc(50% + 60x) becomes calc(50% + 60px)
>  
>  Change-Id: I2ecb732564c405f9315a1ef06e5bd0777c407f19
>  Reviewed-on: https://chromium-review.googlesource.com/1341289
>  WPT-Export-Revision: 72f180571639e8a25b9137e172798fff9356e97a

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 14121 applied with additional changes from upstream: 39c2331ea623e23849d2f6fc99f804e5e2d374d2, 744325921ba52791bc8db1b45d2aed097577753a

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=2eece0eb7d08fe1a29568422f8790aad902e0fff

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=34363f6fa9f6aedd33443f8482bce17c128ccda7

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=6fb603b54e9ea70f371d0880ab77061dda24ca70

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=789aa01679d308211f0e0e4eece2d84daa33a40e

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2136ab447814987afb051ab458957f9cf5c4a64d

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=bdb7096e227889be70cc7e24577a378a84e4cc9b

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Ran 24 tests and 2275 subtests
OK     : 22
PASS   : 2165
FAIL   : 112

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/css/css-align/gaps/column-gap-parsing-001.html
    column-gap accepts calc() mixing fixed and percentage values: FAIL
/css/css-align/gaps/gap-parsing-001.html
    gap accepts calc() mixing fixed and percentage values: FAIL
/css/css-align/gaps/grid-column-gap-parsing-001.html
    grid-column-gap accepts calc() mixing fixed and percentage values: FAIL
/css/css-align/gaps/grid-gap-parsing-001.html
    grid-gap accepts calc() mixing fixed and percentage values: FAIL
/css/css-align/gaps/grid-row-gap-parsing-001.html
    grid-row-gap accepts calc() mixing fixed and percentage values: FAIL
/css/css-align/gaps/row-gap-parsing-001.html
    row-gap accepts calc() mixing fixed and percentage values: FAIL
/web-animations/animation-model/animation-types/accumulation-per-property.html
    flex-basis: calc: FAIL
    flex-basis: units "%" onto "px": FAIL
    flex-basis: units "%" onto "rem": FAIL
    flex-basis: units "calc" onto "px": FAIL
    flex-basis: units "px" onto "%": FAIL
    flex-basis: units "rem" onto "%": FAIL
    word-spacing: calc: FAIL
    word-spacing: units "%" onto "px": FAIL
    word-spacing: units "%" onto "rem": FAIL
    word-spacing: units "calc" onto "px": FAIL
    word-spacing: units "px" onto "%": FAIL
    word-spacing: units "rem" onto "%": FAIL
/web-animations/animation-model/animation-types/addition-per-property.html
    flex-basis: calc: FAIL
    flex-basis: units "%" onto "px": FAIL
    flex-basis: units "%" onto "rem": FAIL
    flex-basis: units "calc" onto "px": FAIL
    flex-basis: units "px" onto "%": FAIL
    flex-basis: units "rem" onto "%": FAIL
    word-spacing: calc: FAIL
    word-spacing: units "%" onto "px": FAIL
    word-spacing: units "%" onto "rem": FAIL
    word-spacing: units "calc" onto "px": FAIL
    word-spacing: units "px" onto "%": FAIL
    word-spacing: units "rem" onto "%": FAIL
/web-animations/animation-model/animation-types/interpolation-per-property.html
    flex-basis supports animating as a calc: FAIL
    flex-basis supports animating as combination units "%" and "em": FAIL
    flex-basis supports animating as combination units "px" and "%": FAIL
    flex-basis supports animating as combination units "px" and "calc": FAIL
    word-spacing supports animating as a calc: FAIL
    word-spacing supports animating as combination units "%" and "em": FAIL
    word-spacing supports animating as combination units "px" and "%": FAIL
    word-spacing supports animating as combination units "px" and "calc": FAIL

New tests that have failures or other problems:
/svg/painting/parsing/stroke-width-computed.svg
    Property stroke-width value '10' computes to '10px': FAIL
    Property stroke-width value 'calc(50% + 60px)' computes to 'calc(50% + 60px)': FAIL

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b28a546614ef20dc19a97875f779651e9b033ada

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f18b7b652c4
[wpt PR 14121] - CSS: Serialize % before px in calc, a=testonly

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/0f18b7b652c4