Closed Bug 1508217 Opened 11 months ago Closed 11 months ago
remove broadcasters from mail/base
+++ This bug was initially created as a clone of Bug #1489447 +++ Remove <broadcaster> from mail/base
Comment on attachment 9026004 [details] [diff] [review] bug1508217_de_broadcaster_otherActionsOpenIn.patch Please rebase. A try run together with bug 1508209 would be great. "try: -b do -p macosx64,linux64 -u all" should be sufficient.
I don't think a rebase is needed. Running on try now: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=23b75edc2e83b2a0dc933ed935e5cb23261de776
Just |hg pull -u| and you'll notice it ;-) - Plus you have two test failures, I'm not sure which of the three patches caused them: TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/message-header/test-header-toolbar.js | test-header-toolbar.js::test_customize_header_toolbar_dialog_style TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/message-header/test-header-toolbar.js | test-header-toolbar.js::test_customize_header_toolbar_change_button_style
Comment on attachment 9026363 [details] [diff] [review] bug1508217_de_broadcaster_otherActionsOpenIn.patch Looks OK to me (I started with and easy one).
Attachment #9026363 - Flags: review?(jorgk) → review+
Pushed by email@example.com: https://hg.mozilla.org/comm-central/rev/72a2e97895e9 remove broadcasters from mail/base. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.