Improve zebra table colors (Network)

RESOLVED FIXED in Firefox 67

Status

defect
P3
normal
RESOLVED FIXED
6 months ago
2 months ago

People

(Reporter: pong7219, Assigned: pong7219)

Tracking

63 Branch
Firefox 67

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

6 months ago
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36

Steps to reproduce:

This is one the last steps of the UX issue from Github.
https://github.com/devtools-html/ux/issues/10

The goal was to come up with better color combination in the Network table.

iteration-network.jpg is the chosen solution.
Thanks for the report!
Honza
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
(Assignee)

Comment 2

4 months ago

Hi :Honza,

Can I try to send a patch to this issue?

I'm getting the latest changes from the Firefox project and maybe I'll struggle with Hg. Does it work like Git?

I'll try to follow these instructions but if you have any other guide I'd appreciate :)
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch

Thanks!

(Assignee)

Comment 3

3 months ago

This changes the colors of the odd table cells and the hover state in rows in the Network tab in DevTools.

I have updated the //--table-zebra-background// in variables.css and inserted a new one, which is //--table-selection-background-hover//.

I have created the new variable, in order to prevent it affecting other table colors.

Posted image image.png

Thanks for the update!

I am getting this (see my screenshot) when testing the changes in Dark mode. It doesn't look as expected.

Honza

Flags: needinfo?(pong7219)
(Assignee)

Comment 5

3 months ago

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #4)

Created attachment 9048479 [details]
image.png

Thanks for the update!

I am getting this (see my screenshot) when testing the changes in Dark mode. It doesn't look as expected.

Honza

Yes, you are right!
I have changed the code so the Dark Mode appearance is unchanged.

Flags: needinfo?(pong7219) → needinfo?(odvarko)

Please, see my phabricator comment

Honza

Flags: needinfo?(odvarko)
(Assignee)

Comment 7

2 months ago

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #6)

Please, see my phabricator comment

Honza

Hi Honza,

Ok! I've sent another commit.

Thanks.

Flags: needinfo?(odvarko)

Comment 8

2 months ago

Can I give it a try ?
@honza

Assignee: nobody → pong7219
Status: NEW → ASSIGNED
Flags: needinfo?(odvarko)

Comment 9

2 months ago
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7c18fe7a050
Change variable colors and set a new one for approved Zebra Colors for Network Tab in DevTools r=Honza

Comment 10

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.