Improve zebra table colors (Network)
Categories
(DevTools :: Netmonitor, defect, P3)
Tracking
(firefox67 fixed)
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: pong7219, Assigned: pong7219)
Details
Attachments
(3 files)
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36 Steps to reproduce: This is one the last steps of the UX issue from Github. https://github.com/devtools-html/ux/issues/10 The goal was to come up with better color combination in the Network table. iteration-network.jpg is the chosen solution.
Comment 1•5 years ago
|
||
Thanks for the report! Honza
Assignee | ||
Comment 2•5 years ago
|
||
Hi :Honza,
Can I try to send a patch to this issue?
I'm getting the latest changes from the Firefox project and maybe I'll struggle with Hg. Does it work like Git?
I'll try to follow these instructions but if you have any other guide I'd appreciate :)
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch
Thanks!
Assignee | ||
Comment 3•5 years ago
|
||
This changes the colors of the odd table cells and the hover state in rows in the Network tab in DevTools.
I have updated the //--table-zebra-background// in variables.css and inserted a new one, which is //--table-selection-background-hover//.
I have created the new variable, in order to prevent it affecting other table colors.
Comment 4•5 years ago
|
||
Thanks for the update!
I am getting this (see my screenshot) when testing the changes in Dark mode. It doesn't look as expected.
Honza
Updated•5 years ago
|
Assignee | ||
Comment 5•5 years ago
|
||
(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #4)
Created attachment 9048479 [details]
image.pngThanks for the update!
I am getting this (see my screenshot) when testing the changes in Dark mode. It doesn't look as expected.
Honza
Yes, you are right!
I have changed the code so the Dark Mode appearance is unchanged.
Assignee | ||
Comment 7•5 years ago
|
||
(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #6)
Please, see my phabricator comment
Honza
Hi Honza,
Ok! I've sent another commit.
Thanks.
Comment 8•5 years ago
|
||
Can I give it a try ?
@honza
Updated•5 years ago
|
Pushed by jodvarko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a7c18fe7a050 Change variable colors and set a new one for approved Zebra Colors for Network Tab in DevTools r=Honza
Comment 10•5 years ago
|
||
bugherder |
Description
•