1508285 - RootFront.listTabs and getTab should return BrowsingContextTargetFront rather than JSON forms

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

Today, BrowsingContextTargetFront are instantiated late, in Target.attach when calling attachTarget:
https://searchfox.org/mozilla-central/rev/5117a4c4e29fcf80a627fecf899a62f117368abf/devtools/client/framework/target.js#532
  const [, targetFront] = await this._client.attachTarget(this.form.actor);
https://searchfox.org/mozilla-central/rev/5117a4c4e29fcf80a627fecf899a62f117368abf/devtools/shared/client/debugger-client.js#375
  front = new BrowsingContextTargetFront(this, { actor: targetActor });

But we should rather let protocol.js auto-marshalling instantiate all the fronts, when calling RootFront.listTabs and RootFront.getTab and than pass the fronts as an argument of Target class.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1508285 - Refactor RootFront.getTab to return BrowsingContextTargetFront instead of JSON form.

MozReview-Commit-ID: 6TOInM5BmYe

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1508285 - Use RootFront.rootForm instead of listTabs to fetch global actors.

MozReview-Commit-ID: Ed5SyZbB0kq

Depends on D14173

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1508285 - Refactor RootFront.listTabs to return BrowsingContextTargetFront instead of JSON form.

MozReview-Commit-ID: 4CMHJ3tV7Rc

Depends on D14174

Comment 4

[Alexandre Poirot [:ochameau]]

Almost green try:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=217393677&revision=7448b47b5dd8e4bef61005514d5699b159060b10

I pushed a fix for the eslint failure.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/433551bcded4
Refactor RootFront.getTab to return BrowsingContextTargetFront instead of JSON form. r=yulia
https://hg.mozilla.org/integration/autoland/rev/c4b0f1c1f723
Use RootFront.rootForm instead of listTabs to fetch global actors. r=yulia
https://hg.mozilla.org/integration/autoland/rev/651250445f44
Refactor RootFront.listTabs to return BrowsingContextTargetFront instead of JSON form. r=yulia,jdescottes

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/433551bcded4
https://hg.mozilla.org/mozilla-central/rev/c4b0f1c1f723
https://hg.mozilla.org/mozilla-central/rev/651250445f44

Comment 7

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732