Closed Bug 1508307 Opened 4 years ago Closed 4 years ago

[remote-dbg-next] This Firefox shows wrong Runtime info when using USB mocks

Categories

(DevTools :: about:debugging, defect, P1)

defect

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1497449

getDeviceDescription() should now return brandName instead of name. I think we should switch gearshere and go back to only exposing a subset of what getDeviceDescription returns.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P3 → P1
Changed my mind about getDeviceDescription :)
I think it is better to remain explicit and to always say which properties we are exporting. 
I also added a small test for the this-firefox mock to avoid future regressions.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4afd2f3b8f33
Rollback getDeviceDescription change and add test for this-firefox mock;r=daisuke
https://hg.mozilla.org/mozilla-central/rev/4afd2f3b8f33
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.