47 bytes, text/x-phabricator-request
|Details | Review|
Regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1497449 getDeviceDescription() should now return brandName instead of name. I think we should switch gearshere and go back to only exposing a subset of what getDeviceDescription returns.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P3 → P1
Changed my mind about getDeviceDescription :) I think it is better to remain explicit and to always say which properties we are exporting. I also added a small test for the this-firefox mock to avoid future regressions.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/4afd2f3b8f33 Rollback getDeviceDescription change and add test for this-firefox mock;r=daisuke
You need to log in before you can comment on or make changes to this bug.