Closed
Bug 1508322
Opened 6 years ago
Closed 6 years ago
[eslint] Define globals that are created as a result of Cu.importGlobalProperties as explicit variables
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox65 fixed)
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
I just realised that we're currently not defining variables imported via Cu.importGlobalProperties as explicit. As a result we're not detecting when these variables are imported but unused (at least for jsm & some test scopes). We already do this for XPCOMUtils.defineLazyGlobalGetters, so we should do the same here.
|
Assignee | |
Comment 1•6 years ago
|
||
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5d0cd55a713 Define 'importGlobalProperties' variables as explicit in ESLint to help identify unused variables. r=mossop
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f5d0cd55a713
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•