Closed Bug 1508343 Opened 11 months ago Closed 11 months ago

Port Bug 1508143: Replace use of tree binding's 'builderView' and 'contentView' with 'view'

Categories

(Thunderbird :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 65.0

People

(Reporter: jorgk, Assigned: Paenglab)

References

Details

Attachments

(1 file)

As per bug 1508143 comment #2:

looks like all references to `builderView` and `contentView` can be replaced with `view` as per Bug 202391 / https://searchfox.org/mozilla-central/rev/b03a62c3c82316e733a3b09622c1cb7e59f64cc3/toolkit/content/widgets/tree.xml#71-78. I don't see any reason not to do this as a cleanup

comm-central will need to be updated as well:

- https://searchfox.org/comm-central/search?q=builderView&path=
- https://searchfox.org/comm-central/search?q=symbol:%23contentView&redirect=false

Only a few call sites or a few more if we edit the suite/ files as well. Richard, could you take this?
Summary: Port Bug 1508143 Remove builderView and contentView from tree binding → Port Bug 1508143: Replace use of tree binding's 'builderView' and 'contentView' with 'view'
I tried the patch and it seems it is still working.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9026173 - Flags: review?(jorgk)
Comment on attachment 9026173 [details] [diff] [review]
1508143-builderView-contentView.patch

Thanks. You found one more than I had spotted before.
Attachment #9026173 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/aa07a415e647
Port bug 1508143: Replace use of tree binding's .builderView and .contentView with .view. r=jorgk

That landed with the wrong bug number :-( - We can still find it via the other bug.
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.