Closed
Bug 1508343
Opened 6 years ago
Closed 6 years ago
Port Bug 1508143: Replace use of tree binding's 'builderView' and 'contentView' with 'view'
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 65.0
People
(Reporter: jorgk-bmo, Assigned: Paenglab)
References
Details
Attachments
(1 file)
|
5.07 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
As per bug 1508143 comment #2: looks like all references to `builderView` and `contentView` can be replaced with `view` as per Bug 202391 / https://searchfox.org/mozilla-central/rev/b03a62c3c82316e733a3b09622c1cb7e59f64cc3/toolkit/content/widgets/tree.xml#71-78. I don't see any reason not to do this as a cleanup comm-central will need to be updated as well: - https://searchfox.org/comm-central/search?q=builderView&path= - https://searchfox.org/comm-central/search?q=symbol:%23contentView&redirect=false Only a few call sites or a few more if we edit the suite/ files as well. Richard, could you take this?
|
Reporter | |
Updated•6 years ago
|
Summary: Port Bug 1508143 Remove builderView and contentView from tree binding → Port Bug 1508143: Replace use of tree binding's 'builderView' and 'contentView' with 'view'
|
Assignee | |
Comment 1•6 years ago
|
||
I tried the patch and it seems it is still working.
|
|
Reporter | |
Comment 2•6 years ago
|
||
Comment on attachment 9026173 [details] [diff] [review] 1508143-builderView-contentView.patch Thanks. You found one more than I had spotted before.
Attachment #9026173 -
Flags: review?(jorgk) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
|
|
Reporter | |
Comment 3•6 years ago
|
||
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/aa07a415e647 Port bug 1508143: Replace use of tree binding's .builderView and .contentView with .view. r=jorgk That landed with the wrong bug number :-( - We can still find it via the other bug.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
|
||
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•