1508346 - Consider having a ListObject class

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jason Orendorff [:jorendorff]]

I wrote a patch for this that it turns out I didn't need.

I don't usually go for this sort of thing, because it's about +50 lines of code net, without actually doing anything different. But perhaps there's a safety argument for doing it anyway. Punting the decision to tcampbell.

Calling this ListObject is a bit misleading; standards use "List" even for things like the entries of a Map or Set, where of course we other data structures. ListObject is just our fallback. I tried to explain this in a comment, but of course that only works to the extent people read it...

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1508346 - Add class ListObject. r?tcampbell

Comment 2

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8e61dc4e9fd0509a9588c03958e94810ce05d69

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1508346 - Add class ListObject. r=jandem

Depends on D12323

Comment 4

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ee79958f7b70cd17e8742ca2b9227233fb9b37d

Comment 5

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea4ebeca224509c62b33333c7bd76fab26e35f2e

Comment 6

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=72fd6a75e55e5c3497156f0723e6734dfb9c0210

Comment 7

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=16da06e1d434b2da7af09ce12a6accb2a803a89a

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac1c8b26e690
Add class ListObject. r=jandem

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ac1c8b26e690