1508379 - Add BinAST version of Instagram to tp6

Status: RESOLVED FIXED

(Testing :: Raptor, enhancement, P1)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This tracks adding BinAST version of Instagram to tp6. Let's try to use the test account created in bug 1508375 for the regular version of Instagram. According to bug 1499463 we'll need to "include the binast mimetype in the request" to enable BinAST.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Bebe: You should be able to work on this now. Please use the BinAST enabled account from the team's shared 1Password vault.

Comment 2

[Florin Strugariu [:Bebe]]

Attachment: Bug 1508379 Add BinAST version of Instagram to tp6

Comment 3

[Florin Strugariu [:Bebe]]

recordings
https://drive.google.com/open?id=1QN3cFgtlc3WtRD-oR3LHr3Q2c67CAMO2

Comment 4

[Florin Strugariu [:Bebe]]

:davehunt :rwood should chrome have any special settings to activate binast?

Comment 5

[Robert Wood [:rwood]]

(In reply to Florin Strugariu [:Bebe] from comment #4)

:davehunt :rwood should chrome have any special settings to activate binast?

Sorry I have no idea, you know way more about binast than I do :)

Comment 6

[Florin Strugariu [:Bebe]]

:vladan do you know how to activate binast on chrome

Comment 7

[Tooru Fujisawa [:arai]]

It's not yet available on google chrome now.

Comment 8

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9670e2386f829e4e004a4fbb501361b2f2a867db

Comment 9

[Florin Strugariu [:Bebe]]

Looks like binast is not loading on win7
https://taskcluster-artifacts.net/VfGn0R4FS-y2k_PaVCoxUQ/0/public/test_info/screenshots.html

Also the getting very different performance results compared with other platforms:

https://treeherder.mozilla.org/perf.html#/graphs?series=try,1872276,1,10&series=try,1872288,1,10&series=try,1872252,1,10&series=try,1872246,1,10&series=try,1872264,1,10&series=try,1872270,1,10

Comment 10

[Florin Strugariu [:Bebe]]

:sdetar are there any known issues with binast and win7?

Comment 11

[Steven DeTar [:sdetar]]

David, could you help answer Florin's question.

Comment 12

[David Teller [:Yoric] - still alive but not very active]

Deflecting to arai!

Comment 13

[David Teller [:Yoric] - still alive but not very active]

(but I seem to remember that we have deactivated BinAST on win32, could this be related?)

Comment 14

[Tooru Fujisawa [:arai]]

There was strange timeout in most-likely unrelated job, only on win32 and android, when the initial implementation was about to be enabled.
I triggered try run with it enabled there.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bac595ca6ccb9f2a8b7d622f5ef2d59fe47a0099

will look into it once the try run finishes.

Comment 15

[Tooru Fujisawa [:arai]]

some more try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a024b98f7261af26282a7b7fcb74b557babe666&group_state=expanded
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4745e0ea90e341fc79c82a7c017e96243eaf542b&group_state=expanded

I guess, now that the implementation is very different than before, and the issue doesn't happen anymore?
will file a bug and post patch there once I confirmed no regression happens there.

Comment 16

[Tooru Fujisawa [:arai]]

enabled on win32 and android, in bug 1527515.
will be merged shortly.

Comment 17

[Florin Strugariu [:Bebe]]

new try build

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f9594c7abbad94f344eb3120766c47ad198a94b

Comment 18

[Florin Strugariu [:Bebe]]

Checked all the builds and the webpages are loading as the should

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b64fc884fc84
Add BinAST version of Instagram to tp6 r=davehunt

Comment 20

[Robert Wood [:rwood]]

Awesome!

Comment 21

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/b64fc884fc84

Comment 22

[David Teller [:Yoric] - still alive but not very active]

So, how could we modify this to get results on more recent versions of BinAST?

Comment 23

[Florin Strugariu [:Bebe]]

we re-recorded all raptor tp6 tests recently.

Bin-ast test is from Playback recording date: 2019-06-26

Do we need it more recent than this?

Comment 24

[David Teller [:Yoric] - still alive but not very active]

Sorry, I wasn't clear.

We're currently working on a new version of BinAST, which uses a new file format. Is there a way for us to manually update the files that you captured to simulate the performance if instagram were to update its own files to the new format – and to compare the two performance results?

Comment 25

[Florin Strugariu [:Bebe]]

manually injecting files in the recording will be quite complicated.
We use mitmproxy to record and playback the capured proxy traffic and we don't have a manual way to modify recording.

The best solution would be if you can provide a local server from where I can record the traffic.

Comment 26

[David Teller [:Yoric] - still alive but not very active]

Unfortunately, we don't have an instagram server :/

Comment 27

[Florin Strugariu [:Bebe]]

Are the new files on instgram? I can record from there...

Comment 28

[David Teller [:Yoric] - still alive but not very active]

No, the idea would be to make the loop shorter. Right now, we have to synchronize with Facebook/Instagram to get them to deploy a new version whenever we want to test the performance of Firefox with new versions of BinAST. I'm looking for a way to do this without having to rely upon Facebook/Instagram.

Comment 29

[Florin Strugariu [:Bebe]]

ok please ping me if you have any solution or want to add/update the binast test in raptor