Closed Bug 1508379 Opened 10 months ago Closed 7 months ago

Add BinAST version of Instagram to tp6

Categories

(Testing :: Raptor, enhancement, P1)

Version 3
enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: davehunt, Assigned: Bebe)

References

Details

Attachments

(1 file)

This tracks adding BinAST version of Instagram to tp6. Let's try to use the test account created in bug 1508375 for the regular version of Instagram. According to bug 1499463 we'll need to "include the binast mimetype in the request" to enable BinAST.
Depends on: 1508392
Status: NEW → ASSIGNED
Priority: -- → P1

Bebe: You should be able to work on this now. Please use the BinAST enabled account from the team's shared 1Password vault.

:davehunt :rwood should chrome have any special settings to activate binast?

Flags: needinfo?(rwood)
Flags: needinfo?(dave.hunt)

(In reply to Florin Strugariu [:Bebe] from comment #4)

:davehunt :rwood should chrome have any special settings to activate binast?

Sorry I have no idea, you know way more about binast than I do :)

Flags: needinfo?(rwood)

:vladan do you know how to activate binast on chrome

Flags: needinfo?(vladan.bugzilla)

It's not yet available on google chrome now.

Flags: needinfo?(vladan.bugzilla)
Flags: needinfo?(dave.hunt)

:sdetar are there any known issues with binast and win7?

Flags: needinfo?(sdetar)

David, could you help answer Florin's question.

Flags: needinfo?(sdetar) → needinfo?(dteller)

Deflecting to arai!

Flags: needinfo?(dteller) → needinfo?(arai.unmht)

(but I seem to remember that we have deactivated BinAST on win32, could this be related?)

There was strange timeout in most-likely unrelated job, only on win32 and android, when the initial implementation was about to be enabled.
I triggered try run with it enabled there.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bac595ca6ccb9f2a8b7d622f5ef2d59fe47a0099

will look into it once the try run finishes.

some more try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a024b98f7261af26282a7b7fcb74b557babe666&group_state=expanded
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4745e0ea90e341fc79c82a7c017e96243eaf542b&group_state=expanded

I guess, now that the implementation is very different than before, and the issue doesn't happen anymore?
will file a bug and post patch there once I confirmed no regression happens there.

Depends on: 1527515

enabled on win32 and android, in bug 1527515.
will be merged shortly.

Flags: needinfo?(arai.unmht)

Checked all the builds and the webpages are loading as the should

Flags: needinfo?(rwood)
Pushed by dhunt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b64fc884fc84
Add BinAST version of Instagram to tp6 r=davehunt

Awesome!

Flags: needinfo?(rwood)
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

So, how could we modify this to get results on more recent versions of BinAST?

Flags: needinfo?(fstrugariu)

we re-recorded all raptor tp6 tests recently.

Bin-ast test is from Playback recording date: 2019-06-26

Do we need it more recent than this?

Flags: needinfo?(fstrugariu) → needinfo?(dteller)

Sorry, I wasn't clear.

We're currently working on a new version of BinAST, which uses a new file format. Is there a way for us to manually update the files that you captured to simulate the performance if instagram were to update its own files to the new format – and to compare the two performance results?

Flags: needinfo?(dteller) → needinfo?(fstrugariu)

manually injecting files in the recording will be quite complicated.
We use mitmproxy to record and playback the capured proxy traffic and we don't have a manual way to modify recording.

The best solution would be if you can provide a local server from where I can record the traffic.

Flags: needinfo?(fstrugariu) → needinfo?(dteller)

Unfortunately, we don't have an instagram server :/

Flags: needinfo?(dteller)

Are the new files on instgram? I can record from there...

Flags: needinfo?(dteller)

No, the idea would be to make the loop shorter. Right now, we have to synchronize with Facebook/Instagram to get them to deploy a new version whenever we want to test the performance of Firefox with new versions of BinAST. I'm looking for a way to do this without having to rely upon Facebook/Instagram.

Flags: needinfo?(dteller) → needinfo?(fstrugariu)

ok please ping me if you have any solution or want to add/update the binast test in raptor

Flags: needinfo?(fstrugariu)
You need to log in before you can comment on or make changes to this bug.