Setting `sparse-profile: None` on a toolchain task produces an error

RESOLVED FIXED in Firefox -esr60

Status

task
RESOLVED FIXED
7 months ago
3 months ago

People

(Reporter: kats, Assigned: tomprince)

Tracking

unspecified
mozilla65

Firefox Tracking Flags

(firefox-esr60 fixed, firefox65 fixed)

Details

Attachments

(1 attachment)

According to [1] a toolchain task should be able to set `sparse-profile: None` to not use a sparse profile. However when actually trying to do so, it produces an error:

[vcs 2018-11-19T20:14:39.356Z] abort: sparse profile build/sparse-profiles/None does not exist at revision 28421835d90c40a8af63ff8d01591e8110f07bac

[1] https://searchfox.org/mozilla-central/rev/b03a62c3c82316e733a3b09622c1cb7e59f64cc3/taskcluster/taskgraph/transforms/job/toolchain.py#54
Also note the only toolchain that tries to take advantage of this actually sets it to `null` instead of `None`:

https://searchfox.org/mozilla-central/rev/b03a62c3c82316e733a3b09622c1cb7e59f64cc3/taskcluster/ci/toolchain/linux.yml#473
That abort message implies that the string "None" is making its way through the config. I'm guessing YAML doesn't recognize `None` as an alias for "undefined" and that `null` is needed instead?

A quick fix for this would be for taskgraph to verify the sparse profile file as specified in the config exists in the current revision.
Assignee

Comment 3

7 months ago
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #0)
> According to [1] a toolchain task should be able to set `sparse-profile:
> None` to not use a sparse profile.

This is because yaml and python spell things differently as :gps suggested. YAML spells `None` as `null`. This could be better documentated, but is working as expected.

(In reply to Gregory Szorc [:gps] from comment #2)
> A quick fix for this would be for taskgraph to verify the sparse profile
> file as specified in the config exists in the current revision.

This would definitely be useful.

Comment 5

7 months ago
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/a9b90a979fc7
[taskgraph] Verify that the specifed sparse profile exists; r=gps
Assignee

Updated

7 months ago
Flags: needinfo?(mozilla)

Comment 7

7 months ago
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/6417da60696e
[taskgraph] Verify that the specifed sparse profile exists; r=gps

Comment 8

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6417da60696e
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Assignee: nobody → mozilla
Target Milestone: Firefox 65 → mozilla65
You need to log in before you can comment on or make changes to this bug.