1508413 - Assertion failure: mProgress != Progress::eReady, at /builds/worker/workspace/build/src/dom/script/ScriptLoadRequest.cpp:121

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect, P2)

Description

[Jason Kratzer [:jkratzer]]

Attachment: testcase.html

Testcase found while fuzzing mozilla-central rev e44bb5b4bc79.  Testcase requires a --enable-fuzzing build.

Assertion failure: mProgress != Progress::eReady, at /builds/worker/workspace/build/src/dom/script/ScriptLoadRequest.cpp:121

rax = 0x0000557498c42e40   rdx = 0x0000000000000000
rcx = 0x00007f0844a705e8   rbx = 0x00007f0834ef8e30
rsi = 0x00007f08514ed8b0   rdi = 0x00007f08514ec680
rbp = 0x00007fff86e622a0   rsp = 0x00007fff86e622a0
r8 = 0x00007f08514ed8b0    r9 = 0x00007f085265e740
r10 = 0x0000000000000000   r11 = 0x0000000000000000
r12 = 0x0000000000000001   r13 = 0x00007f0834ef8ff0
r14 = 0x0000000000000001   r15 = 0x00007fff86e623a0
rip = 0x00007f084128a685
OS|Linux|0.0.0 Linux 4.15.0-38-generic #41-Ubuntu SMP Wed Oct 10 10:59:38 UTC 2018 x86_64
CPU|amd64|family 6 model 78 stepping 3|1
GPU|||
Crash|SIGSEGV /SEGV_MAPERR|0x0|0
0|0|libxul.so|mozilla::dom::ScriptLoadRequest::SetReady()|hg:hg.mozilla.org/mozilla-central:dom/script/ScriptLoadRequest.cpp:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|121|0x0
0|1|libxul.so|mozilla::dom::ModuleLoadRequest::SetReady()|hg:hg.mozilla.org/mozilla-central:dom/script/ModuleLoadRequest.cpp:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|99|0x8
0|2|libxul.so|mozilla::dom::ModuleLoadRequest::ModuleErrored()|hg:hg.mozilla.org/mozilla-central:dom/script/ModuleLoadRequest.cpp:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|129|0x8
0|3|libxul.so|mozilla::MozPromise<nsTArray<bool>, nsresult, false>::ThenValue<mozilla::dom::ModuleLoadRequest*, void (mozilla::dom::ModuleLoadRequest::*)(), void (mozilla::dom::ModuleLoadRequest::*)()>::DoResolveOrRejectInternal(mozilla::MozPromise<nsTArray<bool>, nsresult, false>::ResolveOrRejectValue&)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/MozPromise.h:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|574|0x5
0|4|libxul.so|mozilla::MozPromise<nsTArray<bool>, nsresult, false>::ThenValueBase::ResolveOrRejectRunnable::Run()|hg:hg.mozilla.org/mozilla-central:xpcom/threads/MozPromise.h:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|411|0x8
0|5|libxul.so|nsThread::ProcessNextEvent(bool, bool*)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThread.cpp:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|1244|0x11
0|6|libxul.so|NS_ProcessNextEvent(nsIThread*, bool)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.cpp:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|530|0x11
0|7|libxul.so|mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|97|0xa
0|8|libxul.so|MessageLoop::RunInternal()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|325|0x17
0|9|libxul.so|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|318|0x8
0|10|libxul.so|nsBaseAppShell::Run()|hg:hg.mozilla.org/mozilla-central:widget/nsBaseAppShell.cpp:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|158|0xd
0|11|libxul.so|XRE_RunAppShell()|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|961|0x11
0|12|libxul.so|mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|269|0x5
0|13|libxul.so|MessageLoop::RunInternal()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|325|0x17
0|14|libxul.so|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|318|0x8
0|15|libxul.so|XRE_InitChildProcess(int, char**, XREChildData const*)|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|787|0x8
0|16|firefox-bin|content_process_main(mozilla::Bootstrap*, int, char**)|hg:hg.mozilla.org/mozilla-central:ipc/contentproc/plugin-container.cpp:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|50|0x14
0|17|firefox-bin|main|hg:hg.mozilla.org/mozilla-central:browser/app/nsBrowserApp.cpp:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|287|0x11
0|18|libc-2.27.so||||0x21b97
0|19|firefox-bin|MOZ_ReportAssertionFailure|hg:hg.mozilla.org/mozilla-central:mfbt/Assertions.h:e44bb5b4bc79be613d29b3f95d7b508e68e3d128|164|0x5

Comment 1

[Intermittent Failures Robot]

2 failures in 1862 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-central: 2

Platform breakdown:
* linux64-qr: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1508413&startday=2018-12-03&endday=2018-12-09&tree=all

Comment 2

[Jon Coppeard (:jonco)]

Thanks for the bug report. I'm unable to reproduce this however. It's possible that this has been fixed by a recent change. Do you still see this happening?

(I also a bit confused that the crash involves module loading, but the testcase doesn't use any modules).

Comment 3

[Jason Kratzer [:jkratzer]]

Jon, I can no longer reproduce the issue using the latest m-c build. The fix appears to bisect somewhere in the following range:

[2019-01-28 12:47:41] > Start: 6b7bc40023111979a4755dfeca82629c9c022cd5 (20190124214211)
[2019-01-28 12:47:41] > End: b55ddb97722a51b3365f1a72bdb416f028fd2073 (20190124214415)
[2019-01-28 12:47:41] > Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6b7bc40023111979a4755dfeca82629c9c022cd5&tochange=b55ddb97722a51b3365f1a72bdb416f028fd2073

Comment 4

[Jon Coppeard (:jonco)]

Great. I'm pretty sure this was fixed by some of the changes in bug 1513014.