1508426 - treat "Pure virtual function called!" as an error in logviewer

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, enhancement, P1)

Description

[Alex Gaynor [:Alex_Gaynor]]

(I'm not positive this is the right component)

When a binary we compiled spits out "Pure virtual function called!" on stderr, that means it just hit a fatal error and is about to abort. This piece of information is extremely useful in debugging what happened, it'd be great if the logviewer highlighted these as errors!

Comment 1

[Ed Morley [:emorley]]

Hi! We're no longer accepting regex changes in Treeherder for cases where the test harness/runner should be using appropriate log line prefixes, so in this case mozharness/whatever is wrapping this command will need changing to make:

[task 2018-11-13T04:39:16.872Z] 04:39:16     INFO -  ...

...be output as:

[task 2018-11-13T04:39:16.872Z] 04:39:16    ERROR -  ...

Could you paste the applicable lines from a log and the log URL? :-)

Comment 2

[Alex Gaynor [:Alex_Gaynor]]

Here's a few examples:

- https://treeherder.mozilla.org/logviewer.html#?job_id=211436787&repo=try&lineNumber=5326
- https://treeherder.mozilla.org/logviewer.html#?job_id=211436839&repo=try&lineNumber=1468
- https://treeherder.mozilla.org/logviewer.html#?job_id=211436805&repo=try&lineNumber=1440

Comment 3

[Alex Gaynor [:Alex_Gaynor]]

Interesting, just noticed the exact text differs from what I put in the subject, which was macOS clang (libc++ I guess). On the Linux builds (libstdc++?) it's "pure virtual method called".

Comment 4

[Ed Morley [:emorley]]

The line in question (on Linux at least):

[task 2018-11-13T14:42:13.512Z] 14:42:13     INFO - GECKO(1057) | pure virtual method called

The regexes that need updating are here:
https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/base/errors.py

Comment 5

[Alex Gaynor [:Alex_Gaynor]]

Thanks! It looks like all of the constants in that file are for dealing with different parts of the build system, not compiled binaries themselves. Is there any prior art for this?

Comment 6

[Ed Morley [:emorley]]

I'm not very familiar with mozharness, I'd ask someone from release engineering.

Comment 7

[Alex Gaynor [:Alex_Gaynor]]

Attachment: Bug 1508426 - treat log messages about calling a pure virtual function in a destructor as errors; r?gbrown

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd593d522d24
treat log messages about calling a pure virtual function in a destructor as errors; r=gbrown

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cd593d522d24