Closed Bug 1508441 Opened 3 years ago Closed 2 years ago
[css-contain] contain:size on button shouldn't suppress baseline alignment (but contain:layout should)
Looks like we missed a spot in bug 1491235 -- "contain:size" still seems to suppress baseline alignment on buttons, but it should not. (but contain:layout should) STR: 1. Load attached testcase. EXPECTED RESULTS: - The first two buttons should have the same vertical alignment (honoring the text's baseline). - The last 3 buttons should have the same vertical alignment (not honoring the text's baseline). (Note: TYLin noticed that this might be a problem in bug 1507663 comment 2, via a test that still expects the old now-incorrect behavior.)
"contain:layout" doesn't currently suppress baseline alignment on a few other form controls, too: - <input> type=button, submit, text, number, date, time - <textarea> Let's fix that here as well. I'm adding a reftest in bug 1507663 which covers these & which I'll annotate as 'fails' with a reference to this bug.
The new WPT test in bug 1514838, "css/css-contain/contain-layout-baseline-005.html", also exercises all of these & reveals a few more things where we aren't yet making "contain:layout" suppress baseline: - inline-grid - inline-table
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/7e12e84c8716 part 1: Adjust button reflow to suppress baseline for contain:layout, instead of for contain:size. r=TYLin
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/73c897cf5ec0 followup: adjust reftest failure annotation to point to an updated bug number instead of this closed bug. (no review, test-manifest-only, DONTBUILD)
You need to log in before you can comment on or make changes to this bug.