Closed Bug 1508442 Opened 7 years ago Closed 7 years ago

Give empty protected constructors to field-only GV classes

Categories

(GeckoView :: General, enhancement, P2)

Product:
GeckoView
Component:
General
Type:
enhancement

Tracking

(geckoview64 wontfix, firefox64 wontfix, firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
geckoview64 --- wontfix
firefox64 --- wontfix
firefox65 --- fixed

People

(Reporter: agi, Assigned: agi)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Bug 1508442 - add protected constructor to field-only classes in GeckoView. r?snorp!,esawin!
47 bytes, text/x-phabricator-request
Details | Review
read-only field-only classes like |SecurityInformation| are really hard to use in tests because they don't have a protected constructor. We should give them a dummy empty protected constructor that embedders can use to create Mock classes.
Blocks: 1508977
This adds a dummy `protected`, empty constructor to all field-only classes that don't have one or can't because the constructor uses a private API. This will allow embedders to mock our field-only classes or construct them without having to use reflection.
Pushed by asferro@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/093ef9c7cb94 add protected constructor to field-only classes in GeckoView. r=snorp,esawin
https://hg.mozilla.org/mozilla-central/rev/093ef9c7cb94
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox65: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
64=wontfix because we don't need to uplift this constructor change to 64 Beta.
status-firefox64: --- → wontfix
status-geckoview64=wontfix
status-geckoview64: --- → wontfix
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 65 → mozilla65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: