1508474 - [translate] Unapproving resets the textarea with the translation

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P3)

Description

[Djfe]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

I wrote a translation in the textarea and then unapproved one of the strings below.
I wanted to suggest my string after that.


Actual results:

The textarea was reset to the last translation that I just unapproved.
It deleted my translation.


Expected results:

I definitely didn't expect that to happen.

Comment 1

[Djfe]

Oh and there was no dialog like "You have unsaved changes"

Comment 2

[Matjaz Horvat [:mathjazz]]

The solution here is to check for unsaved changes before executing review actions.

Comment 3

[Sam Odum [:samuelcode]]

Hello Matjaz, I am an Outreachy applicant. Please may I have this issue assigned to me?

Comment 4

[Matjaz Horvat [:mathjazz]]

Hi :samuelcode, I've assigned the bug to you! Please let me know if you have any questions, either here or in #pontoon on IRC.

You can start by installing Pontoon locally using Docker.

Once you have a working local environment, please make sure to read our contribution docs. It contains information on how to style code, how to run tests, how to name your commits, etc. All the things you need to know if you want your work to be merged into Pontoon!

Comment 5

[Matjaz Horvat [:mathjazz]]

We're getting lots of requests by Outreachy participants, so we often run out of Mentored bugs. We've decided to unassign all Mentored bugs until the assignee sets up a development environment.
​
Please send us a screenshot of your working development environment via #pontoon on Mozilla IRC and we'll assign you a Mentored bug afterwards.
​
Thanks for understanding!

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1422

Comment 7

[Matjaz Horvat [:mathjazz]]

https://github.com/mozilla/pontoon/commit/1b4b5f1bfd3d6a302fe8fb2fd6ae4c776f64d46b