1508486 - Default Accept Button on Dialogs doesn't show visual state changes such as mousedown or disabled

Status: NEW

(Core :: Widget: Gtk, defect, P5)

Description

[rb]

Attachment: TBird60DefaultButtonWontShowVisualStateChanges.mp4

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/70.0.3538.77 Chrome/70.0.3538.77 Safari/537.36

Steps to reproduce:

1. Open Account Settings Dialog
2. Press the mouse button down (but don't release it up!) on the "OK" button

This seems to be true for other, possibly all, dialogs using the default "accept"/"OK" button *AND* where that accept button has the attribute default="TRUE" set. If default is not set to "True" then the visual states (mouse-down, disabled, etc) work as normal. 

This is a problem for dialogs (such as Extensions) which attempt to Disable the "OK" button. The button will be functionally disabled (clicking it won't do anything), but it it's visual state will appear as if it is fully enabled.


Actual results:

The OK button fails to show the Mouse-Down visual state.

(It also suppresses / ignores if the visual Disabled attribute state if that is set to true )


Expected results:

The button should show the Mouse-Down state.

Comment 1

[rb]

Also- you can try the following with in a dialog to see how a button having default="true" will suppress it's ability to show the disabled visual, or mouse-down states.

1. document.documentElement.getButton("accept").disabled = true;
(the disabled visual state won't show)

2) document.documentElement.getButton("accept").setAttribute("default", false);
(now the disabled visual state *will* display)

Comment 2

[Richard Marti (:Paenglab)]

I see this too but only on Linux. TB uses the toolkit from Firefox, so moving to XUL widgets.

Comment 3

[rb]

Some additional detail: This issue is also present in Firefox 63.0.3 (Linux) for many dialogs that have an "OK" button. Such as when a print error notice pops up, editing a string value in about:config, etc.

Comment 4

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1552613