1508494 - Setup WNP for users coming from <64.0 and receiving the 64.0 release

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Eric Renaud [:erenaud]]

Request is to have the product point to the /whatsnew page in the Firefox 64.0 release and show it (WNP). 

 - We still need to include id and zh-TW independently, because they have their own template.

- en-GB needs to be included by activating the file manuallyen-US to show up in the URL, you need Peiying to manually activate the file.

- All copy strings will be complete on 11/21

Comment 1

[Francesco Lodolo [:flod]]

(In reply to Eric Renaud [:erenaud] from comment #0)
> - All copy strings will be complete on 11/21

I would point out that we agreed on a calendar where strings would be coded 2 weeks before RC, which is Nov 20.

How much content are we expecting?

Comment 2

[Jeff Beatty [:gueroJeff]]

I also want to note that if we do not receive source strings by the 21st (I would even say by EOD the 20th), this will be a missed target due to the US Thanksgiving holiday.

Comment 3

[Julien Cristau [:jcristau] (back April 22)]

11/21 happened, where are we with this?  AIUI we're too late for l10n, so this is going to be English only, if anything?

Comment 4

[Eric Renaud [:erenaud]]

Apologize for not responding sooner. I communicated with Peiying about this request. 
The strings are in the PR, submitted on 10/21, which Flod and Peiying have already worked on to extract.

https://github.com/mozilla/bedrock/pull/6503

We'll use these strings (some of them, but wholly) only in the WNP for 64.

Comment 5

[Peiying Mo [:CocoMo]]

@Eric, I didn't realize these two projects are related. I thought the content for WNP 64 will be finalized last week.

https://github.com/mozilla/bedrock/pull/6503 - you mentioned that this page would go live on Tuesday (11/27) in English. Localized version will be activated to replace the old Firefox Accounts page as soon as the new page is localized, at the pace of each community. We agreed that when WNP 64 content is ready, it has the priority over other requests. It was not clear these two strings come from this PR.

Which two strings are from this PR?

Comment 6

[Eric Renaud [:erenaud]]

Sorry for the delay - that PR w. strings is here - https://github.com/mozilla/bedrock/pull/6513

Comment 7

[Francesco Lodolo [:flod]]

List of locales:

de
en-GB
en-US
es-ES
fr
id
pl
pt-BR
ru
zh-TW

Comment 8

[Eric Renaud [:erenaud]]

Stephanie - please note the following locales above, for which templates* will need to be hard coded. 

*The template for id already exists and need not be updated

Comment 9

[Tom Prince [:tomprince]]

Attachment: Bug 1508494: Update WNP with locales for 64; r=flod a=whats-new

Comment 10

[Peiying Mo [:CocoMo]]

Localized files in can be found here: https://drive.google.com/drive/folders/1ugH-U5MRaisrAcG7kr-qZOGLD8r-pgBn

Comment 11

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f744e835c8bf

Comment 12

[Julien Cristau [:jcristau] (back April 22)]

Stephanie, https://www.mozilla.org/en-US/firefox/64.0/whatsnew/?oldversion=63.0 is returning an error now, that seems wrong?

Comment 13

[Stephanie Hobson [:shobson]]

Bug with the image paths that only causes problems in production, not our dev environments :/

A fix is on it's way to production. The push should be done by 12:30 EST.

Comment 14

[Julien Cristau [:jcristau] (back April 22)]

Looks good now, thanks Stephanie!

Comment 15

[Ciprian Georgiu, Desktop QA]

We started testing the WNP on "release-localtest" and we're currently encounter an issue with the pt-BR locale. It seems that WNP is not translated for this language and is displayed in english. 

Looks like it should be (per comment 10), any thoughts about this, :flod?

Comment 16

[Francesco Lodolo [:flod]]

We provided the translation, this is on mozilla.org at this point to investigate.

Comment 17

[Stephanie Hobson [:shobson]]

Pmac and I are working on it.

Comment 18

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/55e912479ae47414fc9f67f43d746cc580ce0400
Add locales to Fx 64 WNP

These need to be added manually since the translations are in
the templates themselves.

Re bug 1508494

Comment 19

[Paul [:pmac] McLanahan]

The deployment is fully done now.

Comment 20

[Stephanie Hobson [:shobson]]

Comment 7 lists 'id' in the lists of locales. I just noticed I did not receive a translation for 'id'.

Comment 21

[Stephanie Hobson [:shobson]]

The next comment clarifies. 'id' continues to use the custom template.

Comment 22

[Bogdan Maris, Desktop QA]

Just tested WNP for 64.0.2 (using release-localtest channel) and found something that I'm not sure it's right or wrong.
Updating old release, 'id' or 'zh-TW' locales, to latest (64.0.2) I receive the same WNP image as for en-US. Shouldn't they prompt a different WNP for these two locales?

Comment 23

[Alex Gibson [:agibson]]

(In reply to Bogdan Maris [:bogdan_maris], Release Desktop QA from comment #22)

Just tested WNP for 64.0.2 (using release-localtest channel) and found something that I'm not sure it's right or wrong.
Updating old release, 'id' or 'zh-TW' locales, to latest (64.0.2) I receive the same WNP image as for en-US. Shouldn't they prompt a different WNP for these two locales?

I think I see the problem here, patch incoming.

Comment 24

[Alex Gibson [:agibson]]

Attachment: GitHub Pull Request

Comment 25

[Alex Gibson [:agibson]]

According to https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/views.py#L509, zh-TW is already receiving the correct page (it's not getting an individual WNP for this release, unlike id).

Comment 26

[Alex Gibson [:agibson]]

Fixed in https://github.com/mozilla/bedrock/commit/09427f3b9e933b2bbb2ae722516db96854a7c5d0

This should go to production today in our next push. Thanks for reporting.

Comment 27

[Bogdan Maris, Desktop QA]

(In reply to Alex Gibson [:agibson] from comment #25)

According to https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/views.py#L509, zh-TW is already receiving the correct page (it's not getting an individual WNP for this release, unlike id).

Just to make sure I understand correctly, 'zh-TW' should receive the same WNP as 'en-US' but 'id' should receive a different one.

Comment 28

[Alex Gibson [:agibson]]

Correct.