1508533 - [wpt-sync] Sync PR 14137 - [wpt] Refactor internal function for clarity

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 14137 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14137
Details from upstream follow.

Mike Pennisi <[e-mail]> wrote:
>  [wpt] Refactor internal function for clarity
>  
>  The `affected_by_interfaces` function is used for flow control in the
>  following `if` condition:
>  
>      if rel_path in file_contents or repo_path in file_contents or affected_by_interfaces(file_contents):
>          affected_testfiles.add(test_full_path)
>  
>  This usage suggests that the function should return a boolean value
>  indicating whether the provided file contents are "affected." However,
>  it was previously implemented to interact with the `affected_testfiles`
>  set directly and return `None` in all cases.
>  
>  Refactor the implementation to adhere to the functional style implied by
>  the call site.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6697d0cef45a9f750f9c47c3b432ac884e80a91

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/59c8ec95baa3
[wpt PR 14137] - [wpt] Refactor internal function for clarity, a=testonly

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Result changes from PR not available.

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/59c8ec95baa3