Closed Bug 1508595 Opened 6 years ago Closed 6 years ago

Perma tier2 /service-workers/service-worker/claim-shared-worker-fetch.https.html | fetch() in SharedWorker should be intercepted after the client is claimed. - assert_equals: fetch() in the shared worker should be intercepted. expected

Categories

(Core :: DOM: Service Workers, defect, P5)

Product:
Core
Component:
DOM: Service Workers
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mrbkap)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1508595 - Only set an intercept controller when needed. r=asuth
47 bytes, text/x-phabricator-request
Details | Review 
Filed by: nerli [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=212820634&repo=mozilla-central

https://queue.taskcluster.net/v1/task/Z8AqDCscTo6iPzokbqPiUw/runs/0/artifacts/public/logs/live_backing.log

[task 2018-11-20T07:39:38.180Z] 07:39:38     INFO - TEST-START | /service-workers/service-worker/claim-shared-worker-fetch.https.html
[task 2018-11-20T07:39:38.196Z] 07:39:38     INFO - Closing window 4294967369
[task 2018-11-20T07:39:38.334Z] 07:39:38     INFO - PID 19357 | --DOMWINDOW == 11 (0x7faf21a89400) [pid = 19436] [serial = 2] [outer = (nil)] [url = about:blank]
[task 2018-11-20T07:39:38.335Z] 07:39:38     INFO - PID 19357 | --DOMWINDOW == 10 (0x7faf22c85400) [pid = 19436] [serial = 6] [outer = (nil)] [url = about:blank]
[task 2018-11-20T07:39:38.335Z] 07:39:38     INFO - PID 19357 | --DOMWINDOW == 9 (0x7faf22c86000) [pid = 19436] [serial = 8] [outer = (nil)] [url = about:blank]
[task 2018-11-20T07:39:38.335Z] 07:39:38     INFO - PID 19357 | --DOMWINDOW == 8 (0x7faf22c54000) [pid = 19436] [serial = 5] [outer = (nil)] [url = about:blank]
[task 2018-11-20T07:39:38.539Z] 07:39:38     INFO - PID 19357 | ++DOCSHELL 0x7f2084537800 == 26 [pid = 19459] [id = {3e1320b6-0c2a-4d32-9f1a-82cf0b347e1c}]
[task 2018-11-20T07:39:38.539Z] 07:39:38     INFO - PID 19357 | ++DOMWINDOW == 62 (0x7f2084558c00) [pid = 19459] [serial = 82] [outer = (nil)]
[task 2018-11-20T07:39:38.559Z] 07:39:38     INFO - PID 19357 | ++DOMWINDOW == 63 (0x7f2084559400) [pid = 19459] [serial = 83] [outer = 0x7f2084558c00]
[task 2018-11-20T07:39:38.661Z] 07:39:38     INFO - PID 19357 | ++DOMWINDOW == 64 (0x7f2084561c00) [pid = 19459] [serial = 84] [outer = 0x7f2084558c00]
[task 2018-11-20T07:39:38.847Z] 07:39:38     INFO - PID 19357 | ++DOCSHELL 0x7f208453c800 == 27 [pid = 19459] [id = {2ff765de-acea-4cf3-b8cb-7a1c18ceabef}]
[task 2018-11-20T07:39:38.848Z] 07:39:38     INFO - PID 19357 | ++DOMWINDOW == 65 (0x7f2084564c00) [pid = 19459] [serial = 85] [outer = (nil)]
[task 2018-11-20T07:39:38.930Z] 07:39:38     INFO - PID 19357 | ++DOMWINDOW == 66 (0x7f2084561400) [pid = 19459] [serial = 86] [outer = 0x7f2084564c00]
[task 2018-11-20T07:39:39.075Z] 07:39:39     INFO - PID 19357 | [Parent 19357, Main Thread] WARNING: '!window', file /builds/worker/workspace/build/src/dom/cache/CacheStorage.cpp, line 596
[task 2018-11-20T07:39:39.091Z] 07:39:39     INFO - PID 19357 | [Parent 19357, Main Thread] WARNING: '!window', file /builds/worker/workspace/build/src/dom/cache/CacheStorage.cpp, line 596
[task 2018-11-20T07:39:39.132Z] 07:39:39     INFO - PID 19357 | [Child 19459, Main Thread] WARNING: '!registration', file /builds/worker/workspace/build/src/dom/serviceworkers/ServiceWorkerManager.cpp, line 2104
[task 2018-11-20T07:39:39.132Z] 07:39:39     INFO - PID 19357 | [Child 19459, Main Thread] WARNING: 'error.Failed()', file /builds/worker/workspace/build/src/dom/serviceworkers/ServiceWorkerInterceptController.cpp, line 74
[task 2018-11-20T07:39:39.133Z] 07:39:39     INFO - PID 19357 | [Child 19459, Main Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/netwerk/protocol/http/InterceptedChannel.cpp, line 72
[task 2018-11-20T07:39:39.258Z] 07:39:39     INFO - 
[task 2018-11-20T07:39:39.258Z] 07:39:39     INFO - TEST-UNEXPECTED-FAIL | /service-workers/service-worker/claim-shared-worker-fetch.https.html | fetch() in SharedWorker should be intercepted after the client is claimed. - assert_equals: fetch() in the shared worker should be intercepted. expected "Intercepted!" but got "a simple text file\n"
[task 2018-11-20T07:39:39.259Z] 07:39:39     INFO - @https://web-platform.test:8443/service-workers/service-worker/claim-shared-worker-fetch.https.html:58:11
[task 2018-11-20T07:39:39.259Z] 07:39:39     INFO - promise callback*@https://web-platform.test:8443/service-workers/service-worker/claim-shared-worker-fetch.https.html:57:6
[task 2018-11-20T07:39:39.259Z] 07:39:39     INFO - Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:1568:20
[task 2018-11-20T07:39:39.259Z] 07:39:39     INFO - promise_test/tests.promise_tests</<@https://web-platform.test:8443/resources/testharness.js:591:31
[task 2018-11-20T07:39:39.260Z] 07:39:39     INFO - promise_test/tests.promise_tests<@https://web-platform.test:8443/resources/testharness.js:590:20
[task 2018-11-20T07:39:39.260Z] 07:39:39     INFO - promise callback*promise_test@https://web-platform.test:8443/resources/testharness.js:589:31
[task 2018-11-20T07:39:39.260Z] 07:39:39     INFO - @https://web-platform.test:8443/service-workers/service-worker/claim-shared-worker-fetch.https.html:10:1
[task 2018-11-20T07:39:39.260Z] 07:39:39     INFO - TEST-OK | /service-workers/service-worker/claim-shared-worker-fetch.https.html | took 1081ms
It seems that this is a regression from Bug 1438945
Depends on: 1438945
Assignee: nobody → mrbkap
We only need to expose an intercept controller in SharedWorkers if we're on
the non-parent-intercept version of ServiceWorkers or if e10s is off.
nsDocShell already does this dance and we have to mirror it.
Pushed by mrbkap@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b5e464db402
Only set an intercept controller when needed. r=asuth
https://hg.mozilla.org/mozilla-central/rev/8b5e464db402
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: