Closed
Bug 1508599
Opened 5 years ago
Closed 5 years ago
Don't log error on Fennec when Telemetry is disabled
Categories
(Toolkit :: Telemetry, defect, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox64 | --- | unaffected |
firefox65 | --- | fixed |
People
(Reporter: janerik, Assigned: janerik)
References
Details
Attachments
(1 file)
Bug 1508126 showed that we do log an error when Telemetry is disabled on Fennec. We should check if we can simply avoid logging that error when we know that Telemetry is disabled.
Comment 1•5 years ago
|
||
Does this also affect 64?
status-firefox64:
--- → ?
status-firefox65:
--- → affected
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → jrediger
Points: --- → 1
Priority: -- → P1
Assignee | ||
Comment 2•5 years ago
|
||
Copying over the relevant part from a comment: Looked into it, it's failing at checking if recording is even enabled[1] (...) [1]: https://searchfox.org/mozilla-central/rev/b03a62c3c82316e733a3b09622c1cb7e59f64cc3/toolkit/components/telemetry/core/TelemetryHistogram.cpp#2294-2295 [2]: https://searchfox.org/mozilla-central/rev/b03a62c3c82316e733a3b09622c1cb7e59f64cc3/toolkit/components/telemetry/app/TelemetryController.jsm#583
Assignee | ||
Comment 3•5 years ago
|
||
This is indeed a regression. Previously the error was only logged on exception. Now it is logged when the operation returns false (which can happen because Telemetry is disabled). The new implementation only landed a month ago[1], thus nightly 65. [1]: https://hg.mozilla.org/mozilla-central/rev/26b4dcdfd627
Assignee | ||
Comment 4•5 years ago
|
||
To make it more clear: the only regression is the error being logged. Functionality is the same and correct (it records the stopwatch time to a histogram correctly).
Assignee | ||
Comment 5•5 years ago
|
||
Pushed by jrediger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1062e65758d6 Return a proper result value on accumulate and surpress error when Telemetry is disabled r=chutten
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1062e65758d6
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•