1508611 - Pane separator re-size handle missing in Message Filter window

Status: RESOLVED FIXED

(Thunderbird :: Filters, defect)

Description

[Rob Schofield]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36

Steps to reproduce:

1 Access Message Filter tool by selecting Tools - Message Filters (MF window appears)
2 Select filter name to edit
3 Select Edit (Filter Rules window appears)



Actual results:

Centre pane separator panel (labelled "Perform these actions:") is immovable due to missing re-size grip widget.

The two panes of the filter window are now equal fixed-size and do not allow modification of the display area to match contents (UI functionality modification)


Expected results:

Centre pane separator should contain re-size grip widget to allow pane re-sizing.

Comment 1

[Rob Schofield]

Version of Thunderbird: 60.3.0 (32-bit) running on Win 10 (64-bit). This is a primarily cosmetic issue, but is a retrograde step in functionality of the UI.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: resizer.png

Works for me. The resizer appears when you hover the separator.

Comment 3

[Rob Schofield]

"Works for me" is not what I would expect as a response (professional or otherwise) to a bug report. I've been working in software as a developer and manager for close on 40 years now: if I had received that response to a bug report in our backlog then I would have been furious.

I assume you believe that I am making this up?

Please re-consider the change of status you have applied. 

Windows 10 Home edition (64 bit)/Thunderbird 60.3.1 (32 bit).

I have checked this again. After a reboot and re-start of Thunderbird, I get the same behaviour. Hover does **NOT** work over the centre bar of the filter window. This is a functional failure, probably due to a UI library incompatibility between 32- and 64-bit worlds.

Comment 4

[Rob Schofield]

(In reply to Jorg K (GMT+1) from comment #2)
> Created attachment 9027363 [details]
> resizer.png
> 
> Works for me. The resizer appears when you hover the separator.

You are not verifying this on the same version of UI as I am. I would suggest you verify against a system configuration match.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1508611-filterEditor-splitter.patch

Something must have changed in toolkit. We had already bugs about the wrong cursor on horizontal splitters. When I open the inspector on the filterEditor the splitter appears.

Setting orient="vertical" shows the splitter already on opening the dialog for me.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9027392 [details] [diff] [review]
1508611-filterEditor-splitter.patch

Yes, that adds the missing splitter on trunk. However, it is already working in TB 60 ESR, but we can uplift since it won't hurt.

Maybe the reporter can attach a (small) screenshot of his panel. In my screenshot the line is clearly visible. Also, trying without add-ons (see Help menu) is an option.

Comment 7

[Richard Marti (:Paenglab)]

I don't see it on ESR60 until I use the inspector.

Comment 8

[Jorg K (CEST = GMT+2)]

Hmm. Well, my screenshot is no photo-montage. Anyway, we'll get it uplifted in the next week or so.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b75abd6ba2b3
Set orient="vertical" on splitter in filter editor to show it immediately. r=jorgk

Comment 10

[:aceman]

On Linux the splitter is still not seen after the patch, but that may be correct.
However, on hover the mouse cursor shows indication whether the splitter is a horizontal or vertical. It was showing horizontal before the patch, even though it could only be dragged vertically.
The patch fixes it.
Possibly the default has changed in toolkit, or the 'orient' must be set explicitly.

The same problem exists in SearchDialog.xul, please check all occurrences of <splitter> .

Comment 11

[Jorg K (CEST = GMT+2)]

TB 60.3.2 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/f2bea6614d22d3efdd2274ab7d63d62c18c2590f

Filed 1510035 for message search :-(

Comment 12

[Jorg K (CEST = GMT+2)]

Beta (TB 60 beta 4):
https://hg.mozilla.org/releases/comm-beta/rev/2bc79ecf12c5ea75fe3f3b642807efece7d4f092

Comment 13

[Jorg K (CEST = GMT+2)]

Beta (TB 64 beta 4):
https://hg.mozilla.org/releases/comm-beta/rev/2bc79ecf12c5ea75fe3f3b642807efece7d4f092