1508686 - checkpystyle hook complains incorrectly about missing newlines at the end of files

Status: RESOLVED WORKSFORME

(Developer Services :: Mercurial: mozext, defect)

Description

[(not currently active) Ted Mielczarek]

I've noticed this a few times lately while committing. From just today:

$ hg ci -m "bug 1507827 - start sccache server explicitly in rusttest builds. r?build"
created new head
testing/mozharness/configs/builds/taskcluster_sub_win64/rusttests_opt.py:12:2: W292 no newline at end of file

That file does in fact have a newline at the end! My change to the file consisted of:

diff --git a/testing/mozharness/configs/builds/taskcluster_sub_win64/rusttests_opt.py b/testing/mozha
--- a/testing/mozharness/configs/builds/taskcluster_sub_win64/rusttests_opt.py
+++ b/testing/mozharness/configs/builds/taskcluster_sub_win64/rusttests_opt.py
@@ -1,12 +1,12 @@
 config = {
     'default_actions': [
         'build',
     ],
     'stage_platform': 'win64-rusttests',
     'env': {
         'XPCOM_DEBUG_BREAK': 'stack-and-abort',
     },
-    'build_targets': ['pre-export', 'export', 'recurse_rusttests'],
+    'build_targets': ['start-sccache', 'pre-export', 'export', 'recurse_rusttests'],
     'disable_package_metrics': True,
     'artifact_flag_build_variant_in_try': None,
 }

Comment 1

[Axel Hecht [:Pike]]

This needs a splitlines(True) when passing in lines in critique, to match what https://github.com/PyCQA/pycodestyle/blob/2.2.0/pycodestyle.py#L1508 does.

Comment 2

[Axel Hecht [:Pike]]

Taking, but this raises more trouble than it fixes, at least for the code I work on. Filed bug 1511439 on that.

Comment 3

[Axel Hecht [:Pike]]

Attachment: mozext: include line endings for critic (bug 1508686); r=gps

This matches what pycodestyle does if you pass in a file,
and fixes the problem if you're touching the last line of
a file. Without including the line ending, it raises a warning
about a missing trailing newline.

Comment 4

[Axel Hecht [:Pike]]

Per bug 1511439 comment 1, I added a patch there to just remove `critic`.

Comment 5

[Axel Hecht [:Pike]]

Resolving this as WORKSFORME, as we removed critic.