Closed Bug 1508782 Opened 9 months ago Closed 9 months ago

Create moz.yaml for bspatch

Categories

(Toolkit :: Application Update, enhancement, minor)

enhancement
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: jewilde, Assigned: jewilde)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

A moz.yaml file for bspatch should be added in toolkit/mozapps/update/updater/

The current maintainer seems to be FreeBSD (https://github.com/freebsd/freebsd/tree/master/usr.bin/bsdiff) and the version we are currently using is an older version from Colin Percival (http://www.daemonology.net/bsdiff/)
thanks for filing this.

this is isn't straight forward because moz.yaml is designed to cover all files in a directory rather than just 2 out of a greater list.

probably the simplest fix would be to move bspatch.cpp and bspatch.h under toolkit/mozapps/update/updater/bspatch/ and create the moz.yaml and LICENSE files in there.
No longer blocks: moz.yaml
Depends on: moz.yaml
Thank you, Byron!
It was on my todo list to ask you how this would best be handled after we got back from the holiday.

I'm working on updating our copy of bspatch in another bug so I'll make these changes once that one has landed.
Assignee: nobody → jewilde
Status: NEW → ASSIGNED
Moves bspatch.h and bspatch.cpp into new folder
Adds LICENSE, moz.yaml, and moz.build for bspatch
Alters bsdiff and updater build files to account for the new location of bspatch
Pushed by mhowell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/772261da4442
Add moz.yaml for bspatch in toolkit/mozapps/update; r=mhowell
https://hg.mozilla.org/mozilla-central/rev/772261da4442
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.