Closed Bug 1508782 Opened 9 months ago Closed 9 months ago
.yaml for bspatch
47 bytes, text/x-phabricator-request
|Details | Review|
A moz.yaml file for bspatch should be added in toolkit/mozapps/update/updater/ The current maintainer seems to be FreeBSD (https://github.com/freebsd/freebsd/tree/master/usr.bin/bsdiff) and the version we are currently using is an older version from Colin Percival (http://www.daemonology.net/bsdiff/)
thanks for filing this. this is isn't straight forward because moz.yaml is designed to cover all files in a directory rather than just 2 out of a greater list. probably the simplest fix would be to move bspatch.cpp and bspatch.h under toolkit/mozapps/update/updater/bspatch/ and create the moz.yaml and LICENSE files in there.
Thank you, Byron! It was on my todo list to ask you how this would best be handled after we got back from the holiday. I'm working on updating our copy of bspatch in another bug so I'll make these changes once that one has landed.
Assignee: nobody → jewilde
Status: NEW → ASSIGNED
Moves bspatch.h and bspatch.cpp into new folder Adds LICENSE, moz.yaml, and moz.build for bspatch Alters bsdiff and updater build files to account for the new location of bspatch
Here's a link to the try push I made with this patch https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf747a44dd5f4add7f60ecd33ab86ed7106b1d53&selectedJob=215405171
Here's a link to the try push for the newest revision of the patch https://treeherder.mozilla.org/#/jobs?repo=try&revision=d41c5faaad9d4e9e74cc7b6e9c8713d0fd9e4890
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/772261da4442 Add moz.yaml for bspatch in toolkit/mozapps/update; r=mhowell
You need to log in before you can comment on or make changes to this bug.