84.27 KB, image/jpeg
95.97 KB, image/png
191 bytes, text/html
24.31 KB, patch
Stuart Parmenter: review+
Brian Ryner (not reading): superreview+
|Details | Diff | Splinter Review|
7.25 KB, patch
|Details | Diff | Splinter Review|
Page with such tables is incorrectly rendered, and when you scroll down, it's visible even more. try to browse http://primates.ximian.com/~rodo/obrazky/aquarium/page-1.html
happens with Mozilla 1.0 Mozilla/5.0 (X11; U; Linux ppc; en-US; rv:1.0.0) Gecko/20020606
just wondering what is the problem... what or where badly rendered area.
Riscky: see the attached screenshot, image shadows are wrong (they are not part of the image, image is without them and they are added as background images of table cells, where some of them have col and row span > 1)
Any news on this? Why do you keep it unconfirmed? Don't you experience the same problem on http://primates.ximian.com/~rodo/obrazky/aquarium/page-1.html page?
Created attachment 88754 [details] Incorrect rendering of PNG images with partial transparency on Windoze. Has something to do with the transparency of the .PNG images, not the tables. But it looks uglier on my Windoze macchine.
> Any news on this? Why do you keep it unconfirmed? One of the reasons is that it does not have a reduced testcase.
Created attachment 107817 [details] testcase this is just the shadow_e.png from the URL scaled up. make the browser window small enough to scroll and bad things will happen (as in the previous screenshots)
this is probably a dupe of bug 146202, except that the URL there changed, and so I don't really know what the problem was. See also bug 75558, which describes somewhat similar stuff, but it worksforME. marking NEW ==> Imglib
Retest, as it worksforme, 20030408080, W2K. Can probably be closed.
testcase still exhibits the bug with linux trunk 20030412 might be linux-only
Created attachment 134988 [details] [diff] [review] patch for linux composited image partial updates Fix for the problem on linux. This patch also affects the beos, xlib, and xprint gfx platforms, none of which I'm able to test at the moment. The respective module owners should review/test the patch for their platforms.
Honestly, i don't see this bug in my development builds. Maybe timeless can confirm if it exists or not in BeOS with standard gfx source.
Sergei: BeOS probably wouldn't have exhibited the problem, but the fix required changing one of the backend functions (RectStretch) that gfx/src/beos uses. I'm CCing the other gfx owners so they can check to see if my untesting changes to their code break things.
tor i compiled Mozilla for BeOS with this patch. Seems OK (as it was before). But maybe there are some testcase for image scaling where something may be broken with this patch? To be absolutely sure.
Created attachment 135013 [details] [diff] [review] same as previous plus win32 fix Win32 was doing scaled composited images like this (also the OS/2 approach): 1) read screen region and scale to size of image 2) composite image 3) scale back to screen region and paint While this works for shrinking images, it gives horrible artifacts in the background when scaling up. This patch fixes that, though still shows some artifacts when scrolling the test url for this bug.
Created attachment 135015 [details] [diff] [review] plug memory leak in win32 path
14 years ago
*** Bug 75558 has been marked as a duplicate of this bug. ***
*** Bug 176330 has been marked as a duplicate of this bug. ***
Comment on attachment 135336 [details] [diff] [review] fix xprint build bustage a=asa (on behalf of drivers) for checkin to Mozilla 1.6 beta
Checked in. Leaving bug open for os/2 work.
tor, BeOS build is broken. RectStretch() at line 498 in nsImageBeOS lacks arguments. (while RectStretch at 478 has full set of them.)
BeOS bustage fix checked in.
The "testcase" attachment above, the test case that I posted recently to bug #75558, and the "exteeeemely stretched" example attached to bug #75558 all WFM after the checkin. Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.6b) Gecko/20031123 Firebird/0.7+ (Mike Tigas (Nova)) Thanks!
requesting blocking 1.4.2, Seems to have fixed bug 220576 on Win98.
Comment on attachment 136612 [details] [diff] [review] fix os/2 gfx r=mkaply on patch sr=blizzard a=mkaply for 1.6 a=mkaply for 1.4.2 (I'm doing an OS/2 specific safer patch for that)
all is well. Everything checked in.
re comment 30: > a=mkaply for 1.4.2 (I'm doing an OS/2 specific safer patch for that) Does this mean it will be fixed in 1.4.2 for os/2 only? If there will come a 1.4.2, will it also be for other OS than OS/2, at least Linux and Windows?
Does anyone feel a need to fix this on 1.4.2 for other platforms? The reason I want to fix it for OS/2 is because we are still doing important 1.4.2 releases.
I need to fix this for Beonex (or rather a customer) on the 1.4 branch, but we can do that in our own 1.4-based branch.
*** Bug 231974 has been marked as a duplicate of this bug. ***
Checked in on 1.4 branch - verbal approval from mkaply.
This may have caused bug 250786 ("scaled gifs render as garbage") ...