fix "warning: variant is never constructed: `Quit`"

RESOLVED FIXED in Firefox 65

Status

enhancement
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

Version 3
mozilla65
Points:
---

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

No description provided.
Note that this is a dupe of bug 1396820 which got wontfix. But I really wonder how long we want to carry this variant and its warning until we get the necessary code implemented. Maybe just remove it for now, and add it later when necessary?

ni?'ing James who wontfixed bug 1396820.
Flags: needinfo?(james)
That or you could add #[allow(dead_code)] to the enum, which will silence the warning.
Ah, I assume that the latter would make James happier, and I would also give r+.
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/38b7a780c50f
fix "warning: variant is never constructed: `Quit`" r=ato
https://hg.mozilla.org/mozilla-central/rev/38b7a780c50f
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Flags: needinfo?(james)
Attachment #9026527 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.