Closed
Bug 1508820
Opened 5 years ago
Closed 5 years ago
fix "warning: variant is never constructed: `Quit`"
Categories
(Testing :: geckodriver, enhancement)
Tracking
(firefox65 fixed)
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
Details
Attachments
(1 file, 1 obsolete file)
No description provided.
Assignee | ||
Comment 1•5 years ago
|
||
Comment 2•5 years ago
|
||
Note that this is a dupe of bug 1396820 which got wontfix. But I really wonder how long we want to carry this variant and its warning until we get the necessary code implemented. Maybe just remove it for now, and add it later when necessary? ni?'ing James who wontfixed bug 1396820.
Flags: needinfo?(james)
Assignee | ||
Comment 3•5 years ago
|
||
That or you could add #[allow(dead_code)] to the enum, which will silence the warning.
Comment 4•5 years ago
|
||
Ah, I assume that the latter would make James happier, and I would also give r+.
Assignee | ||
Comment 5•5 years ago
|
||
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/38b7a780c50f fix "warning: variant is never constructed: `Quit`" r=ato
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/38b7a780c50f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Updated•5 years ago
|
Flags: needinfo?(james)
Updated•5 years ago
|
Attachment #9026527 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•