Update Developer Tools Code (DebuggerServer.registerModule is not a function)

RESOLVED FIXED in Thunderbird 65.0

Status

defect
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

Trunk
Thunderbird 65.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

There is an error message DebuggerServer.registerModule is not a function when using Thunderbird. This doesn't seem to inhibit debugging so it wasn't really noticed. Bug 1473578 removed it.

I'm making some updates that fix this issue and consolidate some of the code. Now that we have TabOpen/TabClose events on tabmail, we can mostly use the m-c BrowserTabList.
Posted patch Fix - v1 (obsolete) β€” β€” Splinter Review
Attachment #9026568 - Flags: review?(geoff)
Posted patch Fix - v2 (obsolete) β€” β€” Splinter Review
Attachment #9026568 - Attachment is obsolete: true
Attachment #9026568 - Flags: review?(geoff)
Attachment #9026569 - Flags: review?(geoff)
Comment on attachment 9026569 [details] [diff] [review]
Fix - v2

Review of attachment 9026569 [details] [diff] [review]:
-----------------------------------------------------------------

This is okay by me, although I can't say I know this stuff well. Note there are linting errors.

::: mail/components/devtools/devtools-loader.js
@@ +12,5 @@
>    QueryInterface: ChromeUtils.generateQI([Ci.nsICommandLineHandler]),
>    classID: Components.ID("{089694e9-106a-4704-abf7-62a88545e194}"),
>  
>    helpInfo: "",
> +  handle: function(cmdLine) {

Linter expects method shorthand. And two more below.

@@ +69,5 @@
> +    // Initialize and load the toolkit/browser actors. This will also call above function to set the
> +    // Thunderbird root actor
> +    DebuggerServer.init();
> +    DebuggerServer.registerAllActors();
> +  }

Trailing comma needed.
Attachment #9026569 - Flags: review?(geoff) → review+
Posted patch Fix - v3 β€” β€” Splinter Review
Fixed linting errors now that they show on my env and rebased.
Attachment #9026569 - Attachment is obsolete: true
Attachment #9027077 - Flags: review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d61233a81939
Update Thunderbird devtools root actor and loader. r=darktrojan DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
You need to log in before you can comment on or make changes to this bug.