1508852 - Update Developer Tools Code (DebuggerServer.registerModule is not a function)

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

There is an error message DebuggerServer.registerModule is not a function when using Thunderbird. This doesn't seem to inhibit debugging so it wasn't really noticed. Bug 1473578 removed it.

I'm making some updates that fix this issue and consolidate some of the code. Now that we have TabOpen/TabClose events on tabmail, we can mostly use the m-c BrowserTabList.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9026569 [details] [diff] [review]
Fix - v2

Review of attachment 9026569 [details] [diff] [review]:
-----------------------------------------------------------------

This is okay by me, although I can't say I know this stuff well. Note there are linting errors.

::: mail/components/devtools/devtools-loader.js
@@ +12,5 @@
>    QueryInterface: ChromeUtils.generateQI([Ci.nsICommandLineHandler]),
>    classID: Components.ID("{089694e9-106a-4704-abf7-62a88545e194}"),
>  
>    helpInfo: "",
> +  handle: function(cmdLine) {

Linter expects method shorthand. And two more below.

@@ +69,5 @@
> +    // Initialize and load the toolkit/browser actors. This will also call above function to set the
> +    // Thunderbird root actor
> +    DebuggerServer.init();
> +    DebuggerServer.registerAllActors();
> +  }

Trailing comma needed.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v3

Fixed linting errors now that they show on my env and rebased.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d61233a81939
Update Thunderbird devtools root actor and loader. r=darktrojan DONTBUILD