1508981 - Add/Put should throw TypeError if the arrayBuffer is detached

Status: RESOLVED WORKSFORME

(Core :: Storage: IndexedDB, enhancement, P2)

Description

[Andrea Marchesini [:baku]]

http://w3c.github.io/IndexedDB/#convert-a-value-to-a-key
"If input is a buffer source type - Let octets be the result of running the steps to get a copy of the bytes held by the buffer source input. Rethrow any exceptions."

https://heycam.github.io/webidl/#es-buffer-source-types
"If IsDetachedBuffer(O), then throw a TypeError."

Comment 1

[Andrea Marchesini [:baku]]

Attachment: detached.patch

Would be nice to use ErrorResult::ThrowTypeError<...> but that would require a refactoring of the error reporting in Key.cpp

Comment 2

[Andrea Marchesini [:baku]]

Attachment: detached.patch

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 9026668 [details] [diff] [review]
detached.patch

I'm going to transfer this review to Jan since he's touching other things in this area.  The review may be delayed a bit because of that.

Comment 4

[Jan Varga [:janv]]

This can be a good bug for you. Please refresh the patch and I'll review it.

Comment 5

[Subhamoy [:ssengupta][he/him]]

When I read the spec from here: https://heycam.github.io/webidl/#es-buffer-source-types, it says something different now

If IsDetachedBuffer(arrayBuffer) is true, then return the empty byte sequence.

Perhaps the course of action would be to first revise the tests if necessary, and if the tests then fail, then file a different bug?

Comment 6

[Simon Giesecke [:sg] [he/him]]

Indeed, the wording of this was changed in January by :annevk via https://github.com/heycam/webidl/pull/605

Comment 7

[Jan Varga [:janv]]

Yeah, maybe file a new bug.

Comment 8

[Jens Stutte [:jstutte]]

:ssengupta, you take action here?

Comment 9

[Subhamoy [:ssengupta][he/him]]

I find no discrepancy between spec. and current code here. :baku, would you close this bug then?

Comment 10

[Andrea Marchesini [:baku]]

Spec has changed.