Fix some clang-format comment issues in js/public

RESOLVED FIXED in Firefox -esr60

Status

()

defect
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla65
Points:
---

Firefox Tracking Flags

(firefox-esr60 fixed, firefox65 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 months ago
Minor fixes for places where clang-format messes up.

Very similar to what bug 1508255 did for js/src.

Comment 2

6 months ago
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/834b61114235
Fix some clang-format comment issues in js/public. r=tcampbell

Comment 3

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/834b61114235
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Posted patch ESR patchSplinter Review
[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Comment only change that has baked on trunk for a while

String or UUID changes made by this patch: None
Attachment #9030998 - Flags: approval-mozilla-esr60?
Comment on attachment 9030998 [details] [diff] [review]
ESR patch

OK for uplift to ESR60 as part of the clang-format project.
Attachment #9030998 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.