Closed Bug 1509075 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 14166 - Fix test failure caused by inappropriate event sequencing.

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 14166 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14166
Details from upstream follow.

Harald Alvestrand <hta@chromium.org> wrote:
>  Fix test failure caused by inappropriate event sequencing.
>  
>  This is a minimal fix - move the generation of the track (which
>  causes onnegotiationneeded) to before we set the expectation that
>  no event will be fired.
>  
>  Bug: chromium:905563
>  Change-Id: I879f6eb6130d719d7eaad71fed85044b690f0cb9
>  Reviewed-on: https://chromium-review.googlesource.com/c/1346030
>  Reviewed-by: Guido Urdaneta \<guidou@chromium.org>
>  Commit-Queue: Harald Alvestrand \<hta@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#609999}
>
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests


Tests that are disabled for instability:
/webrtc/RTCPeerConnection-onnegotiationneeded.html
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/30e78e224e8f
[wpt PR 14166] - Fix test failure caused by inappropriate event sequencing., a=testonly
https://hg.mozilla.org/mozilla-central/rev/30e78e224e8f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.