Error when closing the browser languages dialog

RESOLVED FIXED in Firefox 65

Status

()

defect
P2
normal
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: mstriemer, Assigned: mstriemer)

Tracking

unspecified
Firefox 65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

The locales attribute was being removed from the button on close, but since the error message update to include both languages the button is not always in the markup.

An error occurs when the error message gets hidden:

messageBar.querySelector(...) is null; can't access its "removeAttribute" property [1]

[1] https://searchfox.org/mozilla-central/rev/8f89901f2d69d9783f946a7458a6d7ee70635a94/browser/components/preferences/in-content/main.js#842
Previously this would just clear the locales attribute on the button, but the
button isn't always part of the content now. The content is generate in full
when it is shown.
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1bb7cd7e79a4
Clear language change confirmation content on hide r=jaws
https://hg.mozilla.org/mozilla-central/rev/1bb7cd7e79a4
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.