Closed
Bug 1509080
Opened 5 years ago
Closed 5 years ago
Error when closing the browser languages dialog
Categories
(Firefox :: Settings UI, defect, P2)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: mstriemer, Assigned: mstriemer)
References
Details
Attachments
(1 file)
The locales attribute was being removed from the button on close, but since the error message update to include both languages the button is not always in the markup. An error occurs when the error message gets hidden: messageBar.querySelector(...) is null; can't access its "removeAttribute" property [1] [1] https://searchfox.org/mozilla-central/rev/8f89901f2d69d9783f946a7458a6d7ee70635a94/browser/components/preferences/in-content/main.js#842
Assignee | ||
Comment 1•5 years ago
|
||
Previously this would just clear the locales attribute on the button, but the button isn't always part of the content now. The content is generate in full when it is shown.
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1bb7cd7e79a4 Clear language change confirmation content on hide r=jaws
Comment 3•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1bb7cd7e79a4
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in
before you can comment on or make changes to this bug.
Description
•