Closed Bug 1509139 Opened 10 months ago Closed 6 months ago

Port bug 1450652 |Remove the ability to override the node name using XBL|

Categories

(Thunderbird :: General, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: jorgk, Unassigned)

References

Details

As per bug 1450652 comment #7 (quoted here):

... if TB has any bindings that use the [display] / [extends] attribute on <binding> they will need to be migrated away from using it after this patch (which depends on a bit more work being done on the m-c side before it can land).

It looks like this is used in some TB folders: https://searchfox.org/comm-central/search?q=display%3D&path=.xml.

There are bugs blocking this one showing examples of migration - sometimes they can just be removed directly if it's just box/hbox or if it's an element we've already covered on the layout side (like toolbarpaletteitem was covered in Bug 1451256).
Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(geoff)
Flags: needinfo?(arshdkhn1)
Thanks for filing this Jorg.

Just FYI, I'm happy to help out in the migration or writing layout patches if needed, that bug is not blocking anything, just general XBL cleanup, so can wait if necessary.
Depends on: 1509194
(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)
> Thanks for filing this Jorg.
> 
> Just FYI, I'm happy to help out in the migration or writing layout patches
> if needed, that bug is not blocking anything, just general XBL cleanup, so
> can wait if necessary.
Thank you very much Emilio. The display attribute is generaly easy to remove but I am concerned about the extend attribute.
If the bug will remove the support of extends attribute then we ask you to delay it as much as possible. There are a lot of bindings that uses extends attribute. Have you guys dexbled all the m-c bindings that were using these attributes or you have removed these attributes from the bindings?
Flags: needinfo?(arshdkhn1)
I think they're only removing extends="xul:...", Arshad, although I don't totally understand what it did in the first place…
Flags: needinfo?(geoff)
(In reply to Geoff Lankow (:darktrojan) from comment #3)
> I think they're only removing extends="xul:...", Arshad, although I don't
> totally understand what it did in the first place…

Oh that makes sense. Basically if you extend an xul toolkit element then the extended element will have some default behaviours of the toolkit element. e.g., some element extending button will have all those pointer events and other button specific events etc..
Depends on: 1509448
(In reply to Geoff Lankow (:darktrojan) from comment #3)
> I think they're only removing extends="xul:...", Arshad, although I don't
> totally understand what it did in the first place…

Yeah, that's right. extends="xul:.." is effectively an alias to display="xul:..".

All the extends="xul:box" and extends="xul:hbox" can easily be removed without any change I think: https://searchfox.org/comm-central/search?q=extends%3D%22xul%3A&case=false&regexp=false&path=.xml

There are still extends: https://hg.mozilla.org/comm-central/rev/5e366aafa2d5#l1.14 and 9.14 and 10.14 and 13.11.

Extends is fine if it has a URL, not if it starts with xul:.

I think this was all done in other bugs. There is no extends="xul:..." nor any display= in Thunderbird code anymore: https://searchfox.org/comm-central/search?q=extends%3D%22xul%3A&path=

Status: NEW → RESOLVED
Closed: 6 months ago
Flags: needinfo?(mkmelin+mozilla)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.