150915 - Arial is "foo" when toolbar is used to select font

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[Cody 'codeman38' Boisclair]

Steps to reproduce:

1. Create a new message.
2. Type some text.
3. Using the font selector *in the toolbar*, choose "Helvetica, Arial".
4. Select All.
5. View the source using the Insert -> HTML command.

Expected results:  The FONT FACE will be "Helvetica, Arial, sans-serif".

Results:  The FONT FACE is set to "Helvetica, foo, sans-serif".

Interestingly, the font attribute is correctly set if you use the Format->Font
menu instead of the toolbar to choose Helvetica.

Comment 1

[Jean-Francois Ducarroz]

*** Bug 150917 has been marked as a duplicate of this bug. ***

Comment 2

[Joonas]

*** Bug 150917 has been marked as a duplicate of this bug. ***

Comment 3

[Aaron Kaluszka]

I see the problem.  Patch coming up.

Comment 4

[Aaron Kaluszka]

Attachment: Patch

Comment 5

[Aaron Kaluszka]

This is a no-risk patch that needs to also get into the branch.  Reviews needed.

Comment 6

[Aaron Kaluszka]

Attachment: CVS Patch

Here's a real patch against CVS

Comment 7

[Jean-Francois Ducarroz]

reassign to editor team

Comment 8

[Charles Manske]

Comment on attachment 87407 [details] [diff] [review]
CVS Patch

r=cmanske
I wonder how the heck that happened! (CVS Blame doesn't reveal when that
changed was made.)

Comment 9

[Charles Manske]

I have some vague recollection that some Linux users didn't like Arial
Akkana: Do you know anything about this?

Comment 10

[Akkana Peck]

The arial problems on linux are discused in bug 46415.  Redhat had a problem up
through 7.1; I think 7.3 and later are better (my 7.3 machine doesn't have any
Arial at all).  Some other distros had problems as well, especially if they had
installed abiword or Japanese fonts (for some reason those packages come with an
awful scaled-bitmap arial font).  Listing Helvetica before Arial solves the problem.

Comment 11

[Aaron Kaluszka]

CVS claims that the bug was introduced:
1.112 cmanske%netscape.com Aug 9 2000   Big UI fix checkin continued - same 
bugs as last checkin. r=sfraser

If that's true, that would mean there could be a large amount of people 
receiving 'foo' in their mailbox and many webpages with 'foo' in them since it 
would have been included in practically every version of Mozilla and Netscape 
(since M17).

Comment 12

[Kathleen :Brade]

Charley--since this isn't your patch, you may not want to be the "assigned to"
person.

Comment 13

[kinmoz]

Comment on attachment 87407 [details] [diff] [review]
CVS Patch

sr=[e-mail]

Comment 14

[Charles Manske]

checked into trunk

Comment 15

[shrirang khanzode]

gone, verif on trunk 0617.

Comment 16

[scottputterman]

adding adt1.0.1+.  Please get drivers approval before checking into the branch.

Comment 17

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 87407 [details] [diff] [review]
CVS Patch

Approval granted for 1.0 branch checkin; please remove the mozilla1.0.1+
keyword when this is fixed and add the fixed 1.0.1 keyword.

Comment 18

[Charles Manske]

checked into mozilla1.0.1 branch

Comment 19

[R.K.Aa.]

*** Bug 152920 has been marked as a duplicate of this bug. ***

Comment 20

[Joel Nelson (don't send email)]

Regarding Mozilla 1.0.1 branch:  which release version will this be available
in?  I'm using 1.1a and this isn't checked in... is the next version of Mozilla
to be 1.1b or are we going back in version numbers to 1.0.1?
    One other comment...  with Windows users making up over 90% of the computer
market, shouldn't Arial be listed first (Arial, Helvetica, sans-serif)?  Arial
is a common font on Windows systems while it is rare for a Windows system to
have Helvetica.   
   On my Mac OS X system I have both Arial and Helvetica... but I prefer the
look of Arial.
  

Comment 21

[Aaron Kaluszka]

For version number info, see http://www.mozilla.org/roadmap.html
For the reason Helvetica is listed before Arial, see bug 46415.

Comment 22

[sujay]

verified on branch.

Comment 23

[Kathleen :Brade]

*** Bug 160219 has been marked as a duplicate of this bug. ***