1509194 - Massive MozMill Failure in Calendar on 2018-11-21

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

M-C last good: 95a0973a373520f582880ac258e3d2ee7b
M-C first bad: fbd97100c83cc07705244725a3245e6d14
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=95a0973a373520f582880ac258e3d2ee7b&tochange=fbd97100c83cc07705244725a3245e6d14

https://taskcluster-artifacts.net/MV0upWggQeSlTnUy04aiNg/0/public/logs/live_backing.log says:
EXCEPTION: Timeout exceeded for waitForElement Lookup: /id("messengerWindow")/id("tabmail-container")/id("tabmail")/id("tabmail-tabbox")/id("tabpanelcontainer")/id("calendarTabPanel")/id("calendarContent")/id("calendarDisplayDeck")/id("calendar-view-box")/id("view-deck")/id("day-view")/anon({"anonid":"mainbox"})/anon({"anonid":"headerbox"})/anon({"anonid":"headerdaybox"})/[0]/
and more.

Geoff, can you please take a look (I'm afk now).

Comment 1

[Geoff Lankow (:darktrojan)]

Narrowed it to https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e52cc9776809&tochange=fbd97100c83cc07705244725a3245e6d14 with a Try push.

Comment 2

[Geoff Lankow (:darktrojan)]

Probably https://hg.mozilla.org/mozilla-central/rev/b9ccf121cfea. We use that binding for the different calendar views, and I think the mozmill tests click on the tab to switch view.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4ddaece5b962
Temporarily stop using view-tab binding to make tests work again; rs=bustage-fix

Comment 4

[Geoff Lankow (:darktrojan)]

Not using a binding that extends the changed one makes things work again. This has a downside in that the (day, week, multiweek, month) tabs change width slightly when selected as the label is bold. Perhaps we can find some better CSS trickery to make that work, but I think we'll still need to figure out the mechanics of what broke here.

Comment 5

[Geoff Lankow (:darktrojan)]

Huh. That worked when I tried it, and now it doesn't.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/601a4bad47a1
Backed out changeset 4ddaece5b962 ; rs=backout
https://hg.mozilla.org/comm-central/rev/b5146b7bfd61
Convert calendar view selection tabs to radios; rs=bustage-fix

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/781b3615a3ed
Remove accidentally committed change; rs=me

Comment 8

[Geoff Lankow (:darktrojan)]

If this doesn't work (apart from looking wrong), I'm giving up on this bug.

Comment 9

[Jorg K (CEST = GMT+2)]

It appears that you didn't have a good time with this bug :-( - I've been working in "bustage fix" for more than two years now.

So where does this leave us? Is https://hg.mozilla.org/comm-central/rev/b5146b7bfd61 meant to be permanent? Then flag is for review?

And "stop using view-tab binding" appeared to be working and then didn't after all?

Comment 10

[Geoff Lankow (:darktrojan)]

That leaves us with passing tests, and me unhappy with the solution. I would r- it myself, so I've put it to one side for a few hours while I think about a better way.

Comment 11

[Geoff Lankow (:darktrojan)]

Attachment: 1509194-view-selection-tabs-1.diff

This is what landed, plus what I think needs to land to finish it off. Richard, please check this looks okay on Mac and Windows.

I still don't understand what broke the tabs.

Comment 12

[Jorg K (CEST = GMT+2)]

I tried rev 4ddaece5b962 (stop using view-tab binding) but it doesn't let me switch those "view tabs" (Day/Week/Multiweek/Month). Rev b5146b7bfd61/781b3615a3ed work but are a little on the ugly side.

Given that we're busted completely now due to bug 1508056, I'll just go and hibernate for a while.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/95cd4e14ec48
Fix calendar view selection radios styling; rs=me DONTBUILD

Comment 14

[Jorg K (CEST = GMT+2)]

Looks good on Windows and works :-)

Comment 15

[Richard Marti (:Paenglab)]

Comment on attachment 9026909 [details] [diff] [review]
1509194-view-selection-tabs-1.diff

Looks good on Mac and Windows.