1509222 - XUL toolbarbutton with checked="true' but not type="checkbox" doesn't get the pressed state

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P3)

Description

[James Teh [:Jamie]]

STR:
1. Press the Sidebars button on the main toolbar to show the sidebar.
2. Open the Browser Toolbox and the Accessibility panel therein.
3. Find the Sidebars button.
4. Check its states.
Expected: It should have the pressed state.
Actual: It doesn't.

We do support checked="true" for buttons (and thus toolbarbuttons), but only if type="checkbox" or type="radio" is set. It seems there are some toolbar buttons (like the Sidebars button) that don't set type="checkbox" but do set checked="true". We can't know whether to set the checkable state in this case, so the user won't know that it is pressable. Regardless, we should expose the pressed state if checked="true".

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Bug 1509222 - XUL toolbarbutton with checked="true' but not type="checkbox" doesn't get the pressed state, r=Jamie

Simply decouple the check for the checked attribute from the one for the type attribute.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad6143ff142d
XUL toolbarbutton with checked="true' but not type="checkbox" doesn't get the pressed state, r=Jamie

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ad6143ff142d