Closed Bug 1509269 Opened 5 years ago Closed 5 years ago

Log more info about the JS_DefineProperties failure in bug 1488480

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED INVALID

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 obsolete file)

Knowing the type of exception (OOM, object, etc) would tell us what to focus on.
If this is a non-OOM exception (probably an object in that case) we can ignore most code under JS_DefineProperties where we can only throw OOM.

If this is an OOM exception we can try to narrow down where it came from.

Either way I think this will be useful information.
Another thing we could try after this is logging the object's last property name. I wonder if we usually fail after/when defining a particular property. Adding that kind of MOZ_CRASH requires data review so we should probably make it an "instrument everything" patch then.
Priority: -- → P2
I think I'll close this given the new (OOM) information in bug 1488480.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
Attachment #9026912 - Attachment is obsolete: true
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: